code review 1704044: strings and bytes.Split: make count of 0 mean 0, not in...

src/pkg/rpc/server.go

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 /*
         The rpc package provides access to the public methods of an object across a
         network or other I/O connection.  A server registers an object, making it visible
         as a service with the name of the type of the object.  After registration, public
         methods of the object will be accessible remotely.  A server may register multiple
         objects (services) of different types but it is an error to register multiple
@@ skipping 334 matching lines @@
                         if err == os.EOF || err == io.ErrUnexpectedEOF {
                                 if err == io.ErrUnexpectedEOF {
                                         log.Stderr("rpc: ", err)
                                 }
                                 break
                         }
                         s := "rpc: server cannot decode request: " + err.String()
                         sendResponse(sending, req, invalidRequest, codec, s)
                         break
                 }
-                serviceMethod := strings.Split(req.ServiceMethod, ".", 0)
+                serviceMethod := strings.Split(req.ServiceMethod, ".", -1)
                 if len(serviceMethod) != 2 {
                         s := "rpc: service/method request ill-formed: " + req.ServiceMethod
                         sendResponse(sending, req, invalidRequest, codec, s)
                         continue
                 }
                 // Look up the request.
                 server.Lock()
                 service, ok := server.serviceMap[serviceMethod[0]]
                 server.Unlock()
                 if !ok {
@@ skipping 94 matching lines @@
         io.WriteString(conn, "HTTP/1.0 "+connected+"\n\n")
         ServeConn(conn)
 }
 
 // HandleHTTP registers an HTTP handler for RPC messages.
 // It is still necessary to invoke http.Serve(), typically in a go statement.
 func HandleHTTP() {
         http.Handle(rpcPath, http.HandlerFunc(serveHTTP))
         http.Handle(debugPath, http.HandlerFunc(debugHTTP))
 }