Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(158)

Issue 1702052: Trimming URIs before creating proxied URIs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 8 months ago by anupama.dutta
Modified:
15 years, 8 months ago
Reviewers:
johnfargo, shindig.remailer
CC:
cool-shindig-committers_googlegroups.com, gagan.goku, zhoresh
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk
Visibility:
Public.

Description

Leading and trailing whitespaces should be trimmed off before converting the URIs to their proxied forms.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ProxyingVisitor.java View 1 chunk +1 line, -1 line 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ProxyingVisitorTest.java View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5
anupama.dutta
15 years, 8 months ago (2010-07-17 03:27:32 UTC) #1
gagan.goku
On 2010/07/17 03:27:32, anupama.dutta wrote: > lgtm.
15 years, 8 months ago (2010-07-17 04:30:01 UTC) #2
anupama.dutta
15 years, 8 months ago (2010-07-19 11:22:02 UTC) #3
johnfargo
LGTM -- merged w/ Kuntal Loya's CL and committed. Thanks! On 2010/07/19 11:22:02, anupama.dutta wrote: ...
15 years, 8 months ago (2010-07-19 17:14:54 UTC) #4
anupama.dutta
15 years, 8 months ago (2010-07-20 04:47:21 UTC) #5
Thanks, John, for the quick commit!


On Mon, Jul 19, 2010 at 10:44 PM, <johnfargo@gmail.com> wrote:

> LGTM -- merged w/ Kuntal Loya's CL and committed.
>
> Thanks!
>
>
> On 2010/07/19 11:22:02, anupama.dutta wrote:
>
>
>
>
> http://codereview.appspot.com/1702052/show
>



-- 
Anupama
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b