Issue 1702052: Trimming URIs before creating proxied URIs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1702052: Trimming URIs before creating proxied URIs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 8 months ago by anupama.dutta

Modified:
15 years, 8 months ago

Reviewers:
johnfargo, shindig.remailer

CC:
cool-shindig-committers_googlegroups.com, gagan.goku, zhoresh

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk

Visibility:
Public.

Description

Leading and trailing whitespaces should be trimmed off before converting the URIs to their proxied forms.

Patch Set 1 #

Created: 15 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ProxyingVisitor.java	View		1 chunk	+1 line, -1 line	0 comments	Download
		java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ProxyingVisitorTest.java	View		2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

johnfargo

LGTM -- merged w/ Kuntal Loya's CL and committed. Thanks! On 2010/07/19 11:22:02, anupama.dutta wrote: ...

15 years, 8 months ago (2010-07-19 17:14:54 UTC) #4

anupama.dutta

15 years, 8 months ago (2010-07-20 04:47:21 UTC) #5

Thanks, John, for the quick commit!


On Mon, Jul 19, 2010 at 10:44 PM, <johnfargo@gmail.com> wrote:

> LGTM -- merged w/ Kuntal Loya's CL and committed.
>
> Thanks!
>
>
> On 2010/07/19 11:22:02, anupama.dutta wrote:
>
>
>
>
> http://codereview.appspot.com/1702052/show
>



-- 
Anupama

Expand All Messages | Collapse All Messages