Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(376)

Issue 1702050: code review 1702050: strconv.Uitob64: allow conversion of 64-bit binaries (b... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by r
Modified:
12 years, 7 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

strconv.Uitob64: allow conversion of 64-bit binaries (buffer was too small). panic if base is invalid.

Patch Set 1 #

Patch Set 2 : code review 1702050: strconv.Uitob64: allow conversion of 64-bit binaries (b... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/pkg/strconv/itoa.go View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/pkg/strconv/itoa_test.go View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
r
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
12 years, 7 months ago (2010-07-01 21:34:55 UTC) #1
rsc
LGTM add a space to the string in panic On Thu, Jul 1, 2010 at ...
12 years, 7 months ago (2010-07-01 21:40:23 UTC) #2
r
12 years, 7 months ago (2010-07-01 21:44:27 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=f95dbf92973f ***

strconv.Uitob64: allow conversion of 64-bit binaries (buffer was too small).
panic if base is invalid.

R=rsc
CC=golang-dev
http://codereview.appspot.com/1702050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b