Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 1702047: Compute log output only if needed (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 9 months ago by janluehe
Modified:
15 years, 9 months ago
Reviewers:
henry.saputra, dev-remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

This patch adds a check to see if the current log level is set to FINE[ST] before computing the log output and passing it to Logger#fine[st]. I checked that all other places already have this kind of check in place.

Patch Set 1 #

Patch Set 2 : Corrected diffs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/BaseTagRemoverRewriter.java View 1 2 chunks +3 lines, -2 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 3
janluehe
15 years, 9 months ago (2010-06-28 17:38:49 UTC) #1
janluehe
Corrected diffs
15 years, 9 months ago (2010-06-28 17:44:07 UTC) #2
henry.saputra
15 years, 9 months ago (2010-06-28 18:30:11 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b