Issue 170050043: Add comments about Stream.close_connection()'s behavior

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 170050043: Add comments about Stream.close_connection()'s behavior (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by tyoshino (chromium.org)

Modified:
9 years, 5 months ago

Reviewers:
hiroshige

CC:
pywebsocket-reviews_googlegroups.com

Base URL:
http://pywebsocket.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add comments about Stream.close_connection()'s behavior Release note: n/a R=hiroshige@chromium.org Committed: https://code.google.com/p/pywebsocket/source/detail?r=858

Patch Set 3 : Addressed #2 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	src/mod_pywebsocket/_stream_hybi.py	View	1 2	2 chunks	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

hiroshige

https://codereview.appspot.com/170050043/diff/1/src/mod_pywebsocket/_stream_hybi.py File src/mod_pywebsocket/_stream_hybi.py (right): https://codereview.appspot.com/170050043/diff/1/src/mod_pywebsocket/_stream_hybi.py#newcode841 src/mod_pywebsocket/_stream_hybi.py:841: # we can assume that we haven't received any ...

9 years, 5 months ago (2014-11-11 09:21:28 UTC) #2

tyoshino (chromium.org)

9 years, 5 months ago (2014-11-18 06:08:08 UTC) #3

tyoshino (chromium.org)

9 years, 5 months ago (2014-11-25 03:41:52 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as r858 (presubmit successful).

Expand All Messages | Collapse All Messages