fix make update

At the moment is it not possible to deploy a new Rietveld instance. The CL fix it.

Fixes issue 511.

[jfrederich, 2014-11-06 17:18:26]

Hello,

I'd like you to review this change to
https://code.google.com/p/rietveld

[M-A, 2014-11-06 17:24:43]

Thanks, redirecting to Jason.

[jrobbins (chromium), 2014-11-06 19:46:13]

lgtm.

I see what you did and why it is needed.  I think that I will make a slight
change to make explicit Makefile targets for update_frontend and update_backend
and have 'make update' call both in the proper sequence.  The reason is that
your change would remove updating of backends.

I will land this change for you.

[jrobbins (corp), 2014-11-06 20:00:58]

Committed as
https://code.google.com/p/rietveld/source/detail?r=8e0b6ec480472da6f1d79c642b...

[jfrederich, 2014-11-07 08:04:48]

On Thu, Nov 6, 2014 at 8:46 PM,  <jrobbins@chromium.org> wrote:
> lgtm.
>
> I see what you did and why it is needed.  I think that I will make a
> slight change to make explicit Makefile targets for update_frontend and
> update_backend and have 'make update' call both in the proper sequence.
> The reason is that your change would remove updating of backends.
>
> I will land this change for you.
>

Thanks.

Jason, another Rietveld issue drives me crazy,  maybe you have a hint
for me. I'll do some small changes on the Go code review test suite.
The test suite runs fine on my remote testing Rietveld instance. But
on the local instance (App Engine Development Setup) I got always the
following error :

Issue created. URL: http://localhost:7777/1005
Loading /1005/upload_complete/1006: urllib2.HTTPError: HTTP Error 500:
Internal Server Error; trying again in 2 seconds.
abort: HTTP Error 500: Internal Server Error
hg change -i failed

It seems the second upload command is to fast. Any idea what goes wrong?

Jens

[jfrederich, 2014-11-07 14:43:09]

On Nov 7, 2014 9:04 AM, "Jens Frederich" <jfrederich@gmail.com> wrote:
>
> On Thu, Nov 6, 2014 at 8:46 PM,  <jrobbins@chromium.org> wrote:
> > lgtm.
> >
> > I see what you did and why it is needed.  I think that I will make a
> > slight change to make explicit Makefile targets for update_frontend and
> > update_backend and have 'make update' call both in the proper sequence.
> > The reason is that your change would remove updating of backends.
> >
> > I will land this change for you.
> >
>
> Thanks.
>
> Jason, another Rietveld issue drives me crazy,  maybe you have a hint
> for me. I'll do some small changes on the Go code review test suite.
> The test suite runs fine on my remote testing Rietveld instance. But
> on the local instance (App Engine Development Setup) I got always the
> following error :
>
> Issue created. URL: http://localhost:7777/1005
> Loading /1005/upload_complete/1006: urllib2.HTTPError: HTTP Error 500:
> Internal Server Error; trying again in 2 seconds.
> abort: HTTP Error 500: Internal Server Error
> hg change -i failed
>
> It seems the second upload command is to fast. Any idea what goes wrong?
>
On Rietveld the error is: Base file missing.