Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17)

Issue 1699041: Adding AbsolutePathReferenceRewriter (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 9 months ago by gagan.goku
Modified:
15 years, 9 months ago
Reviewers:
johnfargo, zhoresh, shindig.remailer, dev-remailer
CC:
cool-shindig-committers_googlegroups.com
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

1) Adding AbsolutePathReferenceRewriter which will convert all urls to absolute. 2) Refactoring AbsolutePathReferenceVisitor so it is easier to extend it and reuese the basic functionality of extracting all relevant uri's and processing them. Please refer to http://codereview.appspot.com/1674041/show for example of DomainBalancingUriVisitor which extends AbsolutePathReferenceVisitor.

Patch Set 1 #

Patch Set 2 : incorporating_comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -18 lines) Patch
A java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/AbsolutePathReferenceRewriter.java View 1 1 chunk +37 lines, -0 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/AbsolutePathReferenceVisitor.java View 4 chunks +36 lines, -18 lines 0 comments Download

Messages

Total messages: 4
zhoresh
Lgtm, but do you really need the new rewriter class? You can just instantiate the ...
15 years, 9 months ago (2010-06-17 19:40:12 UTC) #1
gagan.goku
On 2010/06/17 19:40:12, zhoresh wrote: > Lgtm, but do you really need the new rewriter ...
15 years, 9 months ago (2010-06-17 19:59:55 UTC) #2
gagan.goku
On 2010/06/17 19:59:55, gagan.goku wrote: > On 2010/06/17 19:40:12, zhoresh wrote: > > Lgtm, but ...
15 years, 9 months ago (2010-06-17 20:03:52 UTC) #3
zhoresh
15 years, 9 months ago (2010-06-17 20:05:56 UTC) #4
sgtm, submitted (r955719)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b