Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(180)

Issue 1698043: code review 1698043: spec: struct tags must be identical for types to be ide... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by rsc
Modified:
11 years, 7 months ago
Reviewers:
CC:
gri, iant, ken2, r, rsc1, golang-dev
Visibility:
Public.

Description

spec: struct tags must be identical for types to be identical We didn't mention this explicitly during our discussions, but I think it fits the "identical types are spelled identically" rule that we used.

Patch Set 1 #

Patch Set 2 : code review 1698043: spec: struct tags must be identical for types to be ide... #

Patch Set 3 : code review 1698043: spec: struct tags must be identical for types to be ide... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M doc/go_spec.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5
rsc
Hello gri, iant, ken, r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
11 years, 7 months ago (2010-06-21 18:56:44 UTC) #1
r2
LGTM
11 years, 7 months ago (2010-06-21 19:34:19 UTC) #2
rsc1
-ken, +ken2
11 years, 7 months ago (2010-06-21 19:37:55 UTC) #3
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=db0189592e62 *** spec: struct tags must be identical for types to be ...
11 years, 7 months ago (2010-06-21 19:42:36 UTC) #4
gri
11 years, 7 months ago (2010-06-23 07:35:23 UTC) #5
LGTM

On Mon, Jun 21, 2010 at 8:56 PM, <rsc@golang.org> wrote:

> Reviewers: gri, iant, yuri.vashchenko_gmail.com, r,
>
> Message:
> Hello gri, iant, ken, r (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> spec: struct tags must be identical for types to be identical
>
> We didn't mention this explicitly during our discussions,
> but I think it fits the "identical types are spelled identically"
> rule that we used.
>
> Please review this at http://codereview.appspot.com/1698043/show
>
> Affected files:
>  M doc/go_spec.html
>
>
> Index: doc/go_spec.html
> ===================================================================
> --- a/doc/go_spec.html
> +++ b/doc/go_spec.html
> @@ -1263,7 +1263,8 @@
>        <li>Two slice types are identical if they have identical element
> types.</li>
>
>        <li>Two struct types are identical if they have the same sequence of
> fields,
> -           and if corresponding fields have the same names and identical
> types.
> +           and if corresponding fields have the same names, and identical
> types,
> +           and identical tags.
>            Two anonymous fields are considered to have the same name.
> Lower-case field
>            names from different packages are always different.</li>
>
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b