code review 1698043: spec: struct tags must be identical for types to be ide...

spec: struct tags must be identical for types to be identical

We didn't mention this explicitly during our discussions,
but I think it fits the "identical types are spelled identically"
rule that we used.

[rsc, 2010-06-21 18:56:44]

Hello gri, iant, ken, r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r2, 2010-06-21 19:34:19]

LGTM

[rsc1, 2010-06-21 19:37:55]

-ken, +ken2

[rsc, 2010-06-21 19:42:36]

*** Submitted as http://code.google.com/p/go/source/detail?r=db0189592e62 ***

spec: struct tags must be identical for types to be identical

We didn't mention this explicitly during our discussions,
but I think it fits the "identical types are spelled identically"
rule that we used.

R=gri, iant, ken2, r, rsc1
CC=golang-dev
http://codereview.appspot.com/1698043

[gri, 2010-06-23 07:35:23]

LGTM

On Mon, Jun 21, 2010 at 8:56 PM, <rsc@golang.org> wrote:

> Reviewers: gri, iant, yuri.vashchenko_gmail.com, r,
>
> Message:
> Hello gri, iant, ken, r (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> spec: struct tags must be identical for types to be identical
>
> We didn't mention this explicitly during our discussions,
> but I think it fits the "identical types are spelled identically"
> rule that we used.
>
> Please review this at http://codereview.appspot.com/1698043/show
>
> Affected files:
>  M doc/go_spec.html
>
>
> Index: doc/go_spec.html
> ===================================================================
> --- a/doc/go_spec.html
> +++ b/doc/go_spec.html
> @@ -1263,7 +1263,8 @@
>        <li>Two slice types are identical if they have identical element
> types.</li>
>
>        <li>Two struct types are identical if they have the same sequence of
> fields,
> -           and if corresponding fields have the same names and identical
> types.
> +           and if corresponding fields have the same names, and identical
> types,
> +           and identical tags.
>            Two anonymous fields are considered to have the same name.
> Lower-case field
>            names from different packages are always different.</li>
>
>
>
>