code review 1697057: fmt.Print: fix bug in placement of spaces introduced wh...

fmt.Print: fix bug in placement of spaces introduced when ...T went in.
Fixes issue 976.

[r, 2010-07-29 17:09:49]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[chris tighe, 2010-07-29 17:18:52]

http://codereview.appspot.com/1697057/diff/6001/7001
File src/pkg/fmt/fmt_test.go (right):

http://codereview.appspot.com/1697057/diff/6001/7001#newcode536
src/pkg/fmt/fmt_test.go:536: t.Errorf("got %q expected %q", got, expect)
I preferred your other way of presenting these kinds of errors:  "expected $q;
got %q" -- i know this is a small nit but i think the way above lends itself to
quicker understanding

http://codereview.appspot.com/1697057/diff/6001/7001#newcode546
src/pkg/fmt/fmt_test.go:546: t.Errorf("got %q expected %q", got, expect)
ditto

[r2, 2010-07-29 17:21:46]

Sure.

-rob

[rsc, 2010-07-29 17:28:36]

> http://codereview.appspot.com/1697057/diff/6001/7001#newcode536
> src/pkg/fmt/fmt_test.go:536: t.Errorf("got %q expected %q", got, expect)
> I preferred your other way of presenting these kinds of errors:
> "expected $q; got %q" -- i know this is a small nit but i think the way
> above lends itself to quicker understanding

it's whatever you're used to; for what it's worth the
rest of the go tree prints = %q want %q (i.e. the
opposite of what you're asking for).

[rsc, 2010-07-29 17:28:56]

LGTM

s/_string/String/g

[r, 2010-07-29 17:50:14]

*** Submitted as http://code.google.com/p/go/source/detail?r=05a5f20be9d8 ***

fmt.Print: fix bug in placement of spaces introduced when ...T went in.
Fixes issue 976.

R=rsc, chris tighe, r
CC=golang-dev
http://codereview.appspot.com/1697057