Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3359)

Issue 1697048: code review 1697048: http, crypto/tls: followup fixes from 1684051. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 9 months ago by agl1
Modified:
3 years, 9 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

	http, crypto/tls: followup fixes from 1684051.

        (TBR because this is just addressing previous review comments.)

Patch Set 1 #

Patch Set 2 : code review 1697048: http, crypto/tls: followup fixes from 1684051. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M src/pkg/crypto/tls/generate_cert.go View 4 chunks +14 lines, -18 lines 0 comments Download
M src/pkg/crypto/tls/tls.go View 3 chunks +4 lines, -4 lines 0 comments Download
M src/pkg/http/server.go View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
agl1
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
3 years, 9 months ago #1
agl1
*** Submitted as http://code.google.com/p/go/source/detail?r=65a544e2c0fd *** http, crypto/tls: followup fixes from 1684051. (TBR because this is ...
3 years, 9 months ago #2
r2
3 years, 9 months ago #3
LGTM


Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5