Adding host and proxy path for Proxy Uris.

1) Adding host and path for proxyied uris without which proxy and concat servlets dont seem to work for default container.
2) Separating out the uri for the default shindig test instance into 2 configs
a) defaultShindigTestHost: "http://localhost:9003",
b) defaultShindigProxyConcatAuthority: "localhost:9003",
with the latter one being the one that gets passed to the call to Uribuilder.setAuthority()

Without this, we were passing on "http://localhost:9003" to setAuthority which is bad.

[gagan.goku, 2010-06-16 23:59:16]

Closing issue as this has been submitted in
http://codereview.appspot.com/1686043/show

[johnfargo, 2010-06-17 21:30:14]

http://codereview.appspot.com/1697041/diff/1/2
File config/container.js (right):

http://codereview.appspot.com/1697041/diff/1/2#newcode95
config/container.js:95: "defaultShindigTestHost": "http://localhost:9003",
why not just remove http:// from this URL and call it a day then?

[gagan.goku, 2010-06-17 21:38:07]

http://codereview.appspot.com/1697041/diff/1/2
File config/container.js (right):

http://codereview.appspot.com/1697041/diff/1/2#newcode95
config/container.js:95: "defaultShindigTestHost": "http://localhost:9003",
On 2010/06/17 21:30:14, johnfargo wrote:
> why not just remove http:// from this URL and call it a day then?

i havent tested DefaultIframeUriManager but maybe your right that it will run
into similar errors.
Check out:
http://www.google.com/codesearch/p?hl=en#gYyO98kxBCI/carbon/dependencies/shin...
line #112

we are doing the same thing, reading a host name and passing "http://hostname"
from config.

Next time i run into similar errors, il remove the http from all occuarances in
this file.

[johnfargo, 2010-06-17 21:40:18]

On Thu, Jun 17, 2010 at 2:38 PM, <gagan.goku@gmail.com> wrote:

>
> http://codereview.appspot.com/1697041/diff/1/2
> File config/container.js (right):
>
> http://codereview.appspot.com/1697041/diff/1/2#newcode95
> config/container.js:95: "defaultShindigTestHost":
> "http://localhost:9003",
> On 2010/06/17 21:30:14, johnfargo wrote:
>
>> why not just remove http:// from this URL and call it a day then?
>>
>
> i havent tested DefaultIframeUriManager but maybe your right that it
> will run into similar errors.
> Check out:
>
>
http://www.google.com/codesearch/p?hl=en#gYyO98kxBCI/carbon/dependencies/shin...
> line #112
>
> we are doing the same thing, reading a host name and passing
> "http://hostname" from config.
>
> Next time i run into similar errors, il remove the http from all
> occuarances in this file.


I wouldn't go that far - but removing http:// (scheme) from tokens that are
used in code purely as host/authority is clearly the right thing to do.
defaultShindigTestHost is only ever used here in this config, not in code,
so what we're really fixing are the gadgets.uri.proxy.host and
gadgets.uri.concat.host values.


>
>
> http://codereview.appspot.com/1697041/show
>

[plindner_linkedin.com, 2010-06-17 23:00:40]

A lot of this config is pretty complex and annoying -- it also is currently
causing samplecontainer to fail.  You have to change 9003 to 8080 in
container.js to get things to run.  Perhaps there could be a way to use the
jetty.port definition?

On Thu, Jun 17, 2010 at 2:40 PM, John Hjelmstad <johnfargo@gmail.com> wrote:

> On Thu, Jun 17, 2010 at 2:38 PM, <gagan.goku@gmail.com> wrote:
>
> >
> > http://codereview.appspot.com/1697041/diff/1/2
> > File config/container.js (right):
> >
> > http://codereview.appspot.com/1697041/diff/1/2#newcode95
> > config/container.js:95: "defaultShindigTestHost":
> > "http://localhost:9003",
> > On 2010/06/17 21:30:14, johnfargo wrote:
> >
> >> why not just remove http:// from this URL and call it a day then?
> >>
> >
> > i havent tested DefaultIframeUriManager but maybe your right that it
> > will run into similar errors.
> > Check out:
> >
> >
>
http://www.google.com/codesearch/p?hl=en#gYyO98kxBCI/carbon/dependencies/shin...
> > line #112
> >
> > we are doing the same thing, reading a host name and passing
> > "http://hostname" from config.
> >
> > Next time i run into similar errors, il remove the http from all
> > occuarances in this file.
>
>
> I wouldn't go that far - but removing http:// (scheme) from tokens that
> are
> used in code purely as host/authority is clearly the right thing to do.
> defaultShindigTestHost is only ever used here in this config, not in code,
> so what we're really fixing are the gadgets.uri.proxy.host and
> gadgets.uri.concat.host values.
>
>
> >
> >
> > http://codereview.appspot.com/1697041/show
> >
>

[johnfargo, 2010-06-17 23:03:24]

In Google we have an implementation of ContainerConfig that expands
${flags.foo} to the value of the flag of name foo (eg. --foo). We could
provide a binding of this sort, but we'd just have to figure out how to
ferry that information from Jetty (or whatever other servlet container) to
the ContainerConfig class. Ideas?

--j

On Thu, Jun 17, 2010 at 4:00 PM, Paul Lindner <plindner@linkedin.com> wrote:

> A lot of this config is pretty complex and annoying -- it also is currently
> causing samplecontainer to fail.  You have to change 9003 to 8080 in
> container.js to get things to run.  Perhaps there could be a way to use the
> jetty.port definition?
>
>
> On Thu, Jun 17, 2010 at 2:40 PM, John Hjelmstad <johnfargo@gmail.com>wrote:
>
>> On Thu, Jun 17, 2010 at 2:38 PM, <gagan.goku@gmail.com> wrote:
>>
>> >
>> > http://codereview.appspot.com/1697041/diff/1/2
>> > File config/container.js (right):
>> >
>> > http://codereview.appspot.com/1697041/diff/1/2#newcode95
>> > config/container.js:95: "defaultShindigTestHost":
>> > "http://localhost:9003",
>> > On 2010/06/17 21:30:14, johnfargo wrote:
>> >
>> >> why not just remove http:// from this URL and call it a day then?
>> >>
>> >
>> > i havent tested DefaultIframeUriManager but maybe your right that it
>> > will run into similar errors.
>> > Check out:
>> >
>> >
>>
http://www.google.com/codesearch/p?hl=en#gYyO98kxBCI/carbon/dependencies/shin...
>> > line #112
>> >
>> > we are doing the same thing, reading a host name and passing
>> > "http://hostname" from config.
>> >
>> > Next time i run into similar errors, il remove the http from all
>> > occuarances in this file.
>>
>>
>> I wouldn't go that far - but removing http:// (scheme) from tokens that
>> are
>> used in code purely as host/authority is clearly the right thing to do.
>> defaultShindigTestHost is only ever used here in this config, not in code,
>> so what we're really fixing are the gadgets.uri.proxy.host and
>> gadgets.uri.concat.host values.
>>
>>
>> >
>> >
>> > http://codereview.appspot.com/1697041/show
>> >
>>
>
>

[johnfargo, 2010-06-17 23:04:20]

FWIW simplest idea might just be to support expansion of -D defs, but that
encodes stuff like "jetty.port" rather than "shindig.port" into our configs.

--j

On Thu, Jun 17, 2010 at 4:03 PM, John Hjelmstad <johnfargo@gmail.com> wrote:

> In Google we have an implementation of ContainerConfig that expands
> ${flags.foo} to the value of the flag of name foo (eg. --foo). We could
> provide a binding of this sort, but we'd just have to figure out how to
> ferry that information from Jetty (or whatever other servlet container) to
> the ContainerConfig class. Ideas?
>
> --j
>
>
> On Thu, Jun 17, 2010 at 4:00 PM, Paul Lindner <plindner@linkedin.com>wrote:
>
>> A lot of this config is pretty complex and annoying -- it also is
>> currently causing samplecontainer to fail.  You have to change 9003 to 8080
>> in container.js to get things to run.  Perhaps there could be a way to use
>> the jetty.port definition?
>>
>>
>> On Thu, Jun 17, 2010 at 2:40 PM, John Hjelmstad <johnfargo@gmail.com>wrote:
>>
>>> On Thu, Jun 17, 2010 at 2:38 PM, <gagan.goku@gmail.com> wrote:
>>>
>>> >
>>> > http://codereview.appspot.com/1697041/diff/1/2
>>> > File config/container.js (right):
>>> >
>>> > http://codereview.appspot.com/1697041/diff/1/2#newcode95
>>> > config/container.js:95: "defaultShindigTestHost":
>>> > "http://localhost:9003",
>>> > On 2010/06/17 21:30:14, johnfargo wrote:
>>> >
>>> >> why not just remove http:// from this URL and call it a day then?
>>> >>
>>> >
>>> > i havent tested DefaultIframeUriManager but maybe your right that it
>>> > will run into similar errors.
>>> > Check out:
>>> >
>>> >
>>>
http://www.google.com/codesearch/p?hl=en#gYyO98kxBCI/carbon/dependencies/shin...
>>> > line #112
>>> >
>>> > we are doing the same thing, reading a host name and passing
>>> > "http://hostname" from config.
>>> >
>>> > Next time i run into similar errors, il remove the http from all
>>> > occuarances in this file.
>>>
>>>
>>> I wouldn't go that far - but removing http:// (scheme) from tokens that
>>> are
>>> used in code purely as host/authority is clearly the right thing to do.
>>> defaultShindigTestHost is only ever used here in this config, not in
>>> code,
>>> so what we're really fixing are the gadgets.uri.proxy.host and
>>> gadgets.uri.concat.host values.
>>>
>>>
>>> >
>>> >
>>> > http://codereview.appspot.com/1697041/show
>>> >
>>>
>>
>>
>