code review 1696062: bytes: add IndexRune, FieldsFunc and To*Special

bytes: add IndexRune, FieldsFunc and To*Special

Basically these functions are implemented the same way as the
corresponding functions in the strings package.  Test functions
are implemented for IndexRune and FieldsFunc.

Additionally two typos are fixed in packages bytes and strings.

[chressie, 2010-08-04 08:30:13]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[chressie, 2010-08-04 08:54:39]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2010-08-04 17:39:32]

R=r

[r2, 2010-08-05 11:23:55]

Looks good, but in the comments please say "UTF-8-encoded Unicode code points". 
It doesn't say that in the strings package, and perhaps it should, but I think
it's important to be clear when talking about bytes.

-rob

[chressie, 2010-08-05 12:15:16]

Hello r (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2010-08-05 12:55:06]

http://codereview.appspot.com/1696062/diff/14001/15001
File src/pkg/bytes/bytes.go (right):

http://codereview.appspot.com/1696062/diff/14001/15001#newcode131
src/pkg/bytes/bytes.go:131: // It returns the byte index of the first occurrence
in s of the Unicode code
You can just say

of the given rune.

The context is clear by now.

http://codereview.appspot.com/1696062/diff/14001/15001#newcode223
src/pkg/bytes/bytes.go:223: // It splits the array s at each run of Unicode code
points c satisfying f(c)
s/Unicode code points/code points/

[chressie, 2010-08-05 13:07:58]

Hello r (cc: golang-dev@googlegroups.com),

Please take another look.

[r2, 2010-08-05 13:10:16]

LGTM and thanks.

-rob

[r, 2010-08-05 13:11:10]

*** Submitted as http://code.google.com/p/go/source/detail?r=e207859ca1a0 ***

bytes: add IndexRune, FieldsFunc and To*Special

Basically these functions are implemented the same way as the
corresponding functions in the strings package.  Test functions
are implemented for IndexRune and FieldsFunc.

Additionally two typos are fixed in packages bytes and strings.

R=r
CC=golang-dev
http://codereview.appspot.com/1696062

Committer: Rob Pike <r@golang.org>