Node tagnames should be case-insensitive

Node tagnames are case-insensitive during the first visit, but were case-sensitive while revisiting causing NullPointerException. They should be case-insensitive always.

[gagan.goku, 2010-07-19 09:34:21]

Looks good.
Question: should we do the same for the attribute name ?

[Kuntal Loya, 2010-07-19 09:36:21]

On 2010/07/19 09:34:21, gagan.goku wrote:
> Looks good.
> Question: should we do the same for the attribute name ?

The parser should ideally do that while creating the DOM from the html. It does
not happen currently and should be fixed separately.

[gagan.goku, 2010-07-19 09:38:11]

On 2010/07/19 09:36:21, Kuntal Loya wrote:
> On 2010/07/19 09:34:21, gagan.goku wrote:
> > Looks good.
> > Question: should we do the same for the attribute name ?
> 
> The parser should ideally do that while creating the DOM from the html. It
does
> not happen currently and should be fixed separately.

This is not fully true, because javascript might be referring to the attribute
which is not lowercased.
No need to do anything more in this cl. But please add a todo in this cl so we
remember to fix it later.

[kuntal, 2010-07-19 10:06:30]

On Mon, Jul 19, 2010 at 3:08 PM, <gagan.goku@gmail.com> wrote:

> On 2010/07/19 09:36:21, Kuntal Loya wrote:
>
>> On 2010/07/19 09:34:21, gagan.goku wrote:
>> > Looks good.
>> > Question: should we do the same for the attribute name ?
>>
>
>  The parser should ideally do that while creating the DOM from the
>>
> html. It does
>
>> not happen currently and should be fixed separately.
>>
>
> This is not fully true, because javascript might be referring to the
> attribute which is not lowercased.
>

Node attributes in JavaScript are case insensitive.



> No need to do anything more in this cl. But please add a todo in this cl
> so we remember to fix it later.
>
>
> http://codereview.appspot.com/1696053/show
>



-- 
Kuntal

[gagan.goku, 2010-07-19 10:11:48]

Nice to know :)

On Mon, Jul 19, 2010 at 3:36 PM, Kuntal Loya <kuntal@google.com> wrote:

>
>
> On Mon, Jul 19, 2010 at 3:08 PM, <gagan.goku@gmail.com> wrote:
>
>> On 2010/07/19 09:36:21, Kuntal Loya wrote:
>>
>>> On 2010/07/19 09:34:21, gagan.goku wrote:
>>> > Looks good.
>>> > Question: should we do the same for the attribute name ?
>>>
>>
>>  The parser should ideally do that while creating the DOM from the
>>>
>> html. It does
>>
>>> not happen currently and should be fixed separately.
>>>
>>
>> This is not fully true, because javascript might be referring to the
>> attribute which is not lowercased.
>>
>
> Node attributes in JavaScript are case insensitive.
>
>
>
>> No need to do anything more in this cl. But please add a todo in this cl
>> so we remember to fix it later.
>>
>>
>> http://codereview.appspot.com/1696053/show
>>
>
>
>
> --
> Kuntal
>

[anupama.dutta, 2010-07-19 11:24:18]

LGTM.
Please add shindig.remailer in reviewer list, and cc johnfargo and zhoresh.

[Kuntal Loya, 2010-07-19 12:19:32]

Node tagnames are case-insensitive during the first visit, but were
case-sensitive while revisiting causing NullPointerException. They should be
case-insensitive always.

[johnfargo, 2010-07-19 17:00:17]

LGTM, submitted. Thanks!

On 2010/07/19 12:19:32, Kuntal Loya wrote:
> Node tagnames are case-insensitive during the first visit, but were
> case-sensitive while revisiting causing NullPointerException. They should be
> case-insensitive always.