Issue 16930043: environs/simplestreams: Log update series errors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 16930043: environs/simplestreams: Log update series errors

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by gz

Modified:
10 years, 6 months ago

Reviewers:
mp+192616, wallyworld

Visibility:
Public.

Description

environs/simplestreams: Log update series errors Rather than returning an error from updateSeriesVersions and then ignoring it, log any issues from reading the ubuntu.csv file. https://code.launchpad.net/~gz/juju-core/log_updateSeriesVersions_1230373/+merge/192616 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : environs/simplestreams: Log update series errors #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	environs/simplestreams/simplestreams.go	View	1	1 chunk	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

wallyworld

LGTM with the fix https://codereview.appspot.com/16930043/diff/1/environs/simplestreams/simplestreams.go File environs/simplestreams/simplestreams.go (right): https://codereview.appspot.com/16930043/diff/1/environs/simplestreams/simplestreams.go#newcode123 environs/simplestreams/simplestreams.go:123: logger.Warningf("failed to update distro info: ...

10 years, 6 months ago (2013-10-25 00:19:30 UTC) #2

Please take a look.

Expand All Messages | Collapse All Messages