Issue 1692055: code review 1692055: 1. got 29 (Mpscale) more bits of precision

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1692055: code review 1692055: 1. got 29 (Mpscale) more bits of precision (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by ken3

Modified:
14 years, 8 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

1. got 29 (Mpscale) more bits of precision out of floating constant multiply 2. added rounding code to "const fix=float" to allow up to 29 (Mpscale) bits of slop and still get an exact fixed constant. fixes issue 931

Patch Set 1 #

Patch Set 2 : code review 1692055: 1. got 29 (Mpscale) more bits of precision #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -4 lines)			Patch
M	src/cmd/gc/mparith1.c	View	2 chunks	+32 lines, -2 lines	0 comments	Download
M	src/cmd/gc/mparith2.c	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/cmd/gc/mparith3.c	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ken3

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-07-17 23:32:38 UTC) #1

ken3

14 years, 8 months ago (2010-07-17 23:32:43 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=dd72bccb5a8d ***

1. got 29 (Mpscale) more bits of precision
out of floating constant multiply
2. added rounding code to "const fix=float"
to allow up to 29 (Mpscale) bits of
slop and still get an exact fixed constant.

fixes issue 931

R=rsc
CC=golang-dev
http://codereview.appspot.com/1692055

Expand All Messages | Collapse All Messages