Issue 1690054: code review 1690054: bug fix: handle alternation involving a regexp

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1690054: code review 1690054: bug fix: handle alternation involving a regexp (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by rsc

Modified:
14 years, 8 months ago

Reviewers:

CC:
rsc, re2-dev_googlegroups.com

Visibility:
Public.

Description

bug fix: handle alternation involving a regexp ending in \C* (or .* in Latin-1 mode) correctly Bug only affected calls to Match, not FullMatch or PartialMatch.

Patch Set 1 #

Patch Set 2 : code review 1690054: bug fix: handle alternation involving a regexp #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -7 lines)			Patch
M	re2/dfa.cc	View	3 chunks	+14 lines, -2 lines	0 comments	Download
M	re2/testing/dfa_test.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	re2/testing/random_test.cc	View	4 chunks	+12 lines, -4 lines	0 comments	Download
M	re2/testing/search_test.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello rsc (cc: re2-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-07-16 02:11:39 UTC) #1

rsc

14 years, 8 months ago (2010-07-16 02:11:43 UTC) #2

*** Submitted as http://code.google.com/p/re2/source/detail?r=01f61ecae9a0 ***

bug fix: handle alternation involving a regexp
ending in \C* (or .* in Latin-1 mode) correctly

Bug only affected calls to Match, not FullMatch or PartialMatch.

R=rsc
CC=re2-dev
http://codereview.appspot.com/1690054

Expand All Messages | Collapse All Messages