Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(236)

Issue 1689062: Fixes issue 1228: support for innerText and textContent to domita.js (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 10 months ago by MikeSamuel
Modified:
15 years, 10 months ago
Reviewers:
Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

http://code.google.com/p/google-caja/issues/detail?id=1228 Adds to domita.js handlers setters and getters for textContent and innerText for TameTextNode and TameElement. Submitted @4229

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -8 lines) Patch
M src/com/google/caja/plugin/domita.js View 8 chunks +51 lines, -7 lines 0 comments Download
M tests/com/google/caja/plugin/domita_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/plugin/domita_test_untrusted.html View 2 chunks +36 lines, -0 lines 2 comments Download

Messages

Total messages: 4
MikeSamuel
15 years, 10 months ago (2010-08-06 23:38:46 UTC) #1
Jasvir
http://codereview.appspot.com/1689062/diff/1/3 File tests/com/google/caja/plugin/domita_test_untrusted.html (right): http://codereview.appspot.com/1689062/diff/1/3#newcode3296 tests/com/google/caja/plugin/domita_test_untrusted.html:3296: testInnerTextNode.innerText = ''; What should innerText be if el.innerHtml ...
15 years, 10 months ago (2010-08-07 00:52:43 UTC) #2
MikeSamuel
http://codereview.appspot.com/1689062/diff/1/3 File tests/com/google/caja/plugin/domita_test_untrusted.html (right): http://codereview.appspot.com/1689062/diff/1/3#newcode3296 tests/com/google/caja/plugin/domita_test_untrusted.html:3296: testInnerTextNode.innerText = ''; On 2010/08/07 00:52:43, jasvir wrote: > ...
15 years, 10 months ago (2010-08-07 01:12:52 UTC) #3
Jasvir
15 years, 10 months ago (2010-08-07 02:02:46 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b