Issue 168780043: code review 168780043: cmd/ld: Generate mach-o debug info when -linkmode=external.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 168780043: code review 168780043: cmd/ld: Generate mach-o debug info when -linkmode=external.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by ribrdb

Modified:
11 years ago

Reviewers:

CC:
golang-codereviews, rsc

Visibility:
Public.

Description

cmd/ld: Generate mach-o debug info when -linkmode=external. Fixes issue 8973.

Patch Set 1 #

Patch Set 2 : diff -r b6ef09a5d00227a49dbc53a715ca9eaa3936f0d3 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b6ef09a5d00227a49dbc53a715ca9eaa3936f0d3 https://code.google.com/p/go/ #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -36 lines)			Patch
M	src/cmd/6l/asm.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/8l/asm.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/ld/dwarf.h	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	src/cmd/ld/dwarf.c	View	1	13 chunks	+82 lines, -29 lines	0 comments	Download
M	src/cmd/ld/lib.c	View	1	1 chunk	+17 lines, -1 line	0 comments	Download
M	src/cmd/ld/macho.c	View	1	3 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ribrdb

Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 2 months ago (2014-10-29 23:12:34 UTC) #1

gobot

11 years ago (2014-12-19 05:15:27 UTC) #3

R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/168780043 is best) in the description in your
new CL.

Thanks very much.

Expand All Messages | Collapse All Messages