Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1455)

Issue 1684051: code review 1684051: crypto/tls, http: Make HTTPS servers easier. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 9 months ago by agl1
Modified:
3 years, 9 months ago
Reviewers:
r, adg, rsc1
CC:
adg, rsc, golang-dev
Visibility:
Public.

Description

crypto/tls, http: Make HTTPS servers easier.

Patch Set 1 #

Patch Set 2 : code review 1684051: crypto/tls, http/https: Make HTTPS servers easier. #

Patch Set 3 : code review 1684051: crypto/tls, http/https: Make HTTPS servers easier. #

Total comments: 4

Patch Set 4 : code review 1684051: crypto/tls, http/https: Make HTTPS servers easier. #

Patch Set 5 : code review 1684051: crypto/tls, http/https: Make HTTPS servers easier. #

Patch Set 6 : code review 1684051: crypto/tls, http: Make HTTPS servers easier. #

Patch Set 7 : code review 1684051: crypto/tls, http: Make HTTPS servers easier. #

Total comments: 11

Patch Set 8 : code review 1684051: crypto/tls, http: Make HTTPS servers easier. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -1 line) Patch
A src/pkg/crypto/tls/generate_cert.go View 6 7 1 chunk +79 lines, -0 lines 0 comments Download
M src/pkg/crypto/tls/tls.go View 1 2 3 4 5 2 chunks +54 lines, -1 line 0 comments Download
M src/pkg/http/server.go View 6 7 3 chunks +52 lines, -0 lines 0 comments Download

Messages

Total messages: 19
agl1
3 years, 9 months ago #1
adg
LGTM A couple of nits below. I'd like to write more of these examples/ directories ...
3 years, 9 months ago #2
agl1
Happy to make the directory 'example' if people like that. http://codereview.appspot.com/1684051/diff/5001/6001 File src/pkg/crypto/tls/examples/generate_cert.go (right): http://codereview.appspot.com/1684051/diff/5001/6001#newcode1 ...
3 years, 9 months ago #3
rsc1
I'm inclined to drop the examples directory and just leave the generate_cert program in the ...
3 years, 9 months ago #4
rsc1
3 years, 9 months ago #5
r2
I think 'examples' is an ok name but singular is fine too. What's important is ...
3 years, 9 months ago #6
r2
On Jul 1, 2010, at 4:24 PM, rsc@google.com wrote: > I'm inclined to drop the ...
3 years, 9 months ago #7
rsc1
I'd like to discuss the example thing separately. Can we leave the example in tls ...
3 years, 9 months ago #8
r2
On Jul 1, 2010, at 4:29 PM, Russ Cox wrote: > I'd like to discuss ...
3 years, 9 months ago #9
rsc1
okay, so i think: move ListenAndServeTLS into package http, dropping http/https move generate_certs.go up one ...
3 years, 9 months ago #10
agl1
On Thu, Jul 1, 2010 at 7:38 PM, <rsc@google.com> wrote: > move generate_certs.go up one ...
3 years, 9 months ago #11
r2
On Jul 2, 2010, at 8:17 AM, Adam Langley wrote: > On Thu, Jul 1, ...
3 years, 9 months ago #12
agl1
On Fri, Jul 2, 2010 at 11:26 AM, Rob 'Commander' Pike <r@google.com> wrote: > Yes ...
3 years, 9 months ago #13
rsc1
LGTM thanks for adding this http://codereview.appspot.com/1684051/diff/23001/24001 File src/pkg/crypto/tls/generate_cert.go (right): http://codereview.appspot.com/1684051/diff/23001/24001#newcode1 src/pkg/crypto/tls/generate_cert.go:1: // Generate a self-signed ...
3 years, 9 months ago #14
agl1
On Fri, Jul 2, 2010 at 12:43 PM, <rsc@google.com> wrote: > LGTM Thanks. Have fixed ...
3 years, 9 months ago #15
agl1
Hello r, adg, rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
3 years, 9 months ago #16
agl1
*** Submitted as http://code.google.com/p/go/source/detail?r=cf7566bf82b6 *** crypto/tls, http: Make HTTPS servers easier. R=r, adg, rsc CC=golang-dev ...
3 years, 9 months ago #17
r
http://codereview.appspot.com/1684051/diff/23001/24001 File src/pkg/crypto/tls/generate_cert.go (right): http://codereview.appspot.com/1684051/diff/23001/24001#newcode20 src/pkg/crypto/tls/generate_cert.go:20: } you might want to use the flags package ...
3 years, 9 months ago #18
agl1
3 years, 9 months ago #19
On Fri, Jul 2, 2010 at 1:02 PM,  <r@golang.org> wrote:
> http://codereview.appspot.com/1684051/diff/23001/24001
> File src/pkg/crypto/tls/generate_cert.go (right):

Even if I wait a while you still manage to comment two minutes after I submit :)

Will fix.


AGL
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5