Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(315)

Issue 1680049: Adding ResponseRewriterRegistry for accel (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 9 months ago by gagan.goku
Modified:
15 years, 9 months ago
Reviewers:
johnfargo, zhoresh, shindig.remailer, dev-remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets
Visibility:
Public.

Description

Implementing a new ResponseRewriterRegistry for accel servlet for specifying response rewriters to be applied for accel.

Patch Set 1 #

Patch Set 2 : Svn up #

Total comments: 2

Patch Set 3 : reverting HtmlAccelServletTest.java #

Patch Set 4 : fixing bad things #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -6 lines) Patch
rewrite/AccelResponseRewriterRegistry.java View 1 chunk +37 lines, -0 lines 0 comments Download
rewrite/RewriteModule.java View 3 3 chunks +12 lines, -2 lines 0 comments Download
servlet/AccelHandler.java View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10
gagan.goku
15 years, 9 months ago (2010-07-07 16:14:50 UTC) #1
gagan.goku
Svn up
15 years, 9 months ago (2010-07-07 16:23:21 UTC) #2
johnfargo
Looks pretty reasonable to me. Can you change the base URL to include java/gadgets/src so ...
15 years, 9 months ago (2010-07-07 18:26:39 UTC) #3
gagan.goku
On 2010/07/07 18:26:39, johnfargo wrote: > Looks pretty reasonable to me. Can you change the ...
15 years, 9 months ago (2010-07-07 18:38:40 UTC) #4
johnfargo
final comment. http://codereview.appspot.com/1680049/diff/3001/4004 File test/java/org/apache/shindig/gadgets/servlet/HtmlAccelServletTest.java (right): http://codereview.appspot.com/1680049/diff/3001/4004#newcode1 test/java/org/apache/shindig/gadgets/servlet/HtmlAccelServletTest.java:1: /* the changes to this file appear ...
15 years, 9 months ago (2010-07-07 18:43:26 UTC) #5
gagan.goku
reverting HtmlAccelServletTest.java
15 years, 9 months ago (2010-07-07 18:49:25 UTC) #6
gagan.goku
http://codereview.appspot.com/1680049/diff/3001/4004 File test/java/org/apache/shindig/gadgets/servlet/HtmlAccelServletTest.java (right): http://codereview.appspot.com/1680049/diff/3001/4004#newcode1 test/java/org/apache/shindig/gadgets/servlet/HtmlAccelServletTest.java:1: /* On 2010/07/07 18:43:26, johnfargo wrote: > the changes ...
15 years, 9 months ago (2010-07-07 18:49:39 UTC) #7
gagan.goku
fixing bad things
15 years, 9 months ago (2010-07-07 18:54:34 UTC) #8
johnfargo
Committed, thx! On 2010/07/07 18:54:34, gagan.goku wrote: > fixing bad things
15 years, 9 months ago (2010-07-08 02:16:40 UTC) #9
gagan.goku
15 years, 9 months ago (2010-07-08 16:54:01 UTC) #10
On 2010/07/08 02:16:40, johnfargo wrote:
> Committed, thx!
> 
> On 2010/07/07 18:54:34, gagan.goku wrote:
> > fixing bad things

Thanks
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b