code review 1678054: codereview: don't run gofmt with an empty file list

codereview: don't run gofmt with an empty file list

[rsc, 2010-07-15 23:13:08]

Hello gri (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[gri, 2010-07-15 23:17:50]

LGTM

On Thu, Jul 15, 2010 at 4:13 PM, <rsc@golang.org> wrote:

> Reviewers: gri,
>
> Message:
> Hello gri (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> codereview: don't run gofmt with an empty file list
>
> Please review this at http://codereview.appspot.com/1678054/show
>
> Affected files:
>  M lib/codereview/codereview.py
>
>
> Index: lib/codereview/codereview.py
> ===================================================================
> --- a/lib/codereview/codereview.py
> +++ b/lib/codereview/codereview.py
> @@ -694,6 +694,8 @@
>        cwd = os.getcwd()
>        files = [RelativePath(repo.root + '/' + f, cwd) for f in files]
>        files = [f for f in files if os.access(f, 0)]
> +       if not files:
> +               return
>        try:
>                cmd = subprocess.Popen(["gofmt", "-l"] + files, shell=False,
> stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE,
> close_fds=True)
>                cmd.stdin.close()
>
>
>

[rsc, 2010-07-15 23:43:08]

*** Submitted as http://code.google.com/p/go/source/detail?r=87f6114950fc ***

codereview: don't run gofmt with an empty file list

R=gri
CC=golang-dev
http://codereview.appspot.com/1678054