Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 167059: Issue 1165: fixed testCustomEvent on opera (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 3 months ago by MikeSamuel
Modified:
16 years, 3 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Opera supports both addEventListener and attachEvent but events created using the DOM standard mechanism can only be dispatched to listeners added using addEventListener. Fixed @3899

Patch Set 1 #

Total comments: 4

Patch Set 2 : Issue 1165: fixed testCustomEvent on opera #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M src/com/google/caja/plugin/bridal.js View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/plugin/HtmlCompiledPluginTest.java View 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/plugin/domita_test.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tests/com/google/caja/plugin/jsunit.js View 1 3 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 4
MikeSamuel
16 years, 3 months ago (2009-12-09 03:47:28 UTC) #1
felix8a
http://codereview.appspot.com/167059/diff/1/4 File tests/com/google/caja/plugin/domita_test_untrusted.html (right): http://codereview.appspot.com/167059/diff/1/4#newcode2620 tests/com/google/caja/plugin/domita_test_untrusted.html:2620: assertEquals("received correct event", 'hiya', event.details); spacing http://codereview.appspot.com/167059/diff/1/3 File tests/com/google/caja/plugin/jsunit.js ...
16 years, 3 months ago (2009-12-09 09:20:38 UTC) #2
MikeSamuel
http://codereview.appspot.com/167059/diff/1/4 File tests/com/google/caja/plugin/domita_test_untrusted.html (right): http://codereview.appspot.com/167059/diff/1/4#newcode2620 tests/com/google/caja/plugin/domita_test_untrusted.html:2620: assertEquals("received correct event", 'hiya', event.details); On 2009/12/09 09:20:38, felix8a ...
16 years, 3 months ago (2009-12-09 21:45:32 UTC) #3
felix8a
16 years, 3 months ago (2009-12-09 21:49:18 UTC) #4
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b