Fix 1112.

Fix 1112.
Add support for minimum-distance into the page-breaker.

[Neil Puttock, 2010-06-20 20:12:52]

LGTM.

http://codereview.appspot.com/1670042/diff/1/2
File input/regression/page-breaking-min-distance.ly (right):

http://codereview.appspot.com/1670042/diff/1/2#newcode1
input/regression/page-breaking-min-distance.ly:1: \version "2.13.22"
2.13.26

http://codereview.appspot.com/1670042/diff/1/2#newcode9
input/regression/page-breaking-min-distance.ly:9: between-scores-system-spacing
#'minimum-distance = #'20
#20

http://codereview.appspot.com/1670042/diff/1/2#newcode18
input/regression/page-breaking-min-distance.ly:18: 
There's an extra newline following this row (whitespace error: new blank line at
EOF)

http://codereview.appspot.com/1670042/diff/1/3
File lily/constrained-breaking.cc (right):

http://codereview.appspot.com/1670042/diff/1/3#newcode384
lily/constrained-breaking.cc:384: Line_details for anything.  That's because the
approximations
Is this still true?  It appears to be used in several places.

http://codereview.appspot.com/1670042/diff/1/3#newcode406
lily/constrained-breaking.cc:406: SCM page_breaking_spacing_spec = l->c_variable
("page-breaking-between-system-spacing");
Is this here for future use or is it left over from your original spacing patch?

[joeneeman, 2010-06-21 18:28:52]

Thanks, fixed. I'll push after "make check" finishes...

http://codereview.appspot.com/1670042/diff/1/3
File lily/constrained-breaking.cc (right):

http://codereview.appspot.com/1670042/diff/1/3#newcode384
lily/constrained-breaking.cc:384: Line_details for anything.  That's because the
approximations
On 2010/06/20 20:12:52, Neil Puttock wrote:
> Is this still true?  It appears to be used in several places.

We read it in several places, but we never set it to anything other than zero.
So it's ready to be used as soon as we decide to set it to something better than
zero, but I don't know what that is yet...

http://codereview.appspot.com/1670042/diff/1/3#newcode406
lily/constrained-breaking.cc:406: SCM page_breaking_spacing_spec = l->c_variable
("page-breaking-between-system-spacing");
On 2010/06/20 20:12:52, Neil Puttock wrote:
> Is this here for future use or is it left over from your original spacing
patch?

It's read in lines 413 and 425 (but I see that it isn't documented correctly in
the NR...)

[Neil Puttock, 2010-06-22 21:21:16]

On 2010/06/21 18:28:52, joeneeman wrote:

> We read it in several places, but we never set it to anything other than zero.
> So it's ready to be used as soon as we decide to set it to something better
than
> zero, but I don't know what that is yet...

Ah, I see.  So the same applies to between_system_space_ in
Constrained_breaking.
 
> It's read in lines 413 and 425 (but I see that it isn't documented correctly
in
> the NR...)

It doesn't look very useful. :)

Cheers,
Neil