Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(194)

Issue 16700043: Convert fetching proxy tests to client-side tests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by kpreid2
Modified:
12 years, 4 months ago
Reviewers:
ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This allows the tests to be reused for a proxy written for a different server platform. Also added a test of Unicode-correctness, and found and fixed an precedence-based error which made USE_AS_PROXY useless. @r5619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -2 lines) Patch
M build.xml View 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/plugin/caja.js View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/plugin/browser-tests.json View 1 chunk +1 line, -0 lines 0 comments Download
A tests/com/google/caja/plugin/test-fetch-proxy.js View 1 chunk +199 lines, -0 lines 0 comments Download
A tests/com/google/caja/plugin/test-fetch-proxy-fixture.css View 1 chunk +1 line, -0 lines 0 comments Download
A tests/com/google/caja/plugin/test-fetch-proxy-fixture-unicode.ujs View 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/service/ProxyHandlerTest.java View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/com/google/caja/util/LocalServer.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2
kpreid2
12 years, 4 months ago (2013-10-24 18:48:32 UTC) #1
ihab.awad
12 years, 4 months ago (2013-10-24 19:03:05 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b