Issue 1666046: Issue 1237: Playground runs script before cajoled HTML laid out.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1666046: Issue 1237: Playground runs script before cajoled HTML laid out. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 9 months ago by MikeSamuel

Modified:
15 years, 9 months ago

Reviewers:
Jasvir

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

The offsetWidth,offsetHeight, etc. are only valid for HTML elements that are part of the DOM and laid out. If any ancestor is display:none then it will not be laid out so offsetWidth,etc. return stale data. This changes PlaygroundView to make the editor tab visible before the dynamic JS portion of the cajoled output is run. Submitted @4159

Patch Set 1 #

Created: 15 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
	M	src/com/google/caja/demos/playground/client/ui/PlaygroundView.java	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	src/com/google/caja/demos/playground/taming.js	View		4 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages