Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(556)

Issue 1665049: code review 1665049: factor common prefix strings out of alternation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 9 months ago by rsc
Modified:
14 years, 9 months ago
Reviewers:
CC:
rsc, re2-dev_googlegroups.com
Visibility:
Public.

Description

factor common prefix strings out of alternation

Patch Set 1 #

Patch Set 2 : code review 1665049: factor common prefix strings out of alternation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -9 lines) Patch
M re2/parse.cc View 8 chunks +228 lines, -6 lines 0 comments Download
M re2/regexp.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M re2/testing/parse_test.cc View 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 2
rsc
Hello rsc (cc: re2-dev@googlegroups.com), I'd like you to review this change.
14 years, 9 months ago (2010-07-16 01:26:00 UTC) #1
rsc
14 years, 9 months ago (2010-07-16 01:26:04 UTC) #2
*** Submitted as http://code.google.com/p/re2/source/detail?r=473388a6c2c4 ***

factor common prefix strings out of alternation

R=rsc
CC=re2-dev
http://codereview.appspot.com/1665049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b