Issue 166420043: ibus-setup tries C since en_US.UTF-8 is not installed in Debian by default.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 166420043: ibus-setup tries C since en_US.UTF-8 is not installed in Debian by default. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by fujiwara

Modified:
9 years, 5 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara, osamu_debian.org

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

ibus-setup tries C since en_US.UTF-8 is not installed in Debian by default. BUG=https://code.google.com/p/ibus/issues/detail?id=1747 TEST=setup

Patch Set 2 : Updated with message #2. #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	setup/enginecombobox.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	setup/enginedialog.py	View	1	1 chunk	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

https://codereview.appspot.com/166420043/diff/1/setup/enginedialog.py File setup/enginedialog.py (right): https://codereview.appspot.com/166420043/diff/1/setup/enginedialog.py#newcode340 setup/enginedialog.py:340: self.__untrans_for_lang[l] = untrans Those code are duplicate with line ...

9 years, 5 months ago (2014-11-10 16:15:47 UTC) #2

fujiwara

9 years, 5 months ago (2014-11-11 07:13:06 UTC) #3

lgtm

Expand All Messages | Collapse All Messages