Issue 1662041: code review 1662041: remove uses of ... from tree, add one test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1662041: code review 1662041: remove uses of ... from tree, add one test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by rsc

Modified:
14 years, 10 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

remove uses of ... from tree, add one test

Patch Set 1 #

Patch Set 2 : code review 1662041: remove uses of ... from tree, add one test #

Patch Set 3 : code review 1662041: remove uses of ... from tree, add one test #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -47 lines)			Patch
M	src/pkg/exp/datafmt/datafmt.go	View		5 chunks	+10 lines, -7 lines	0 comments	Download
M	src/pkg/exp/datafmt/datafmt_test.go	View		3 chunks	+2 lines, -12 lines	0 comments	Download
M	src/pkg/reflect/all_test.go	View	1	3 chunks	+26 lines, -2 lines	0 comments	Download
M	src/pkg/reflect/type.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/testing/script/script.go	View	1	2 chunks	+7 lines, -3 lines	0 comments	Download
R	test/fixedbugs/bug153.go	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	test/fixedbugs/bug228.go	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	test/fixedbugs/bug232.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/fixedbugs/bug252.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 10 months ago (2010-06-12 19:03:37 UTC) #1

rsc

14 years, 10 months ago (2010-06-14 18:23:25 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=28d00af269dc ***

remove uses of ... from tree, add one test

R=r
CC=golang-dev
http://codereview.appspot.com/1662041

Expand All Messages | Collapse All Messages