code review 166190043: lib/codereview: testing mode on a remote Rietveld instance

lib/codereview: testing mode on a remote Rietveld instance

With the coderiew extension testing mode is it possible to
test the extension with a local Rietveld instance, which is
running using the App Engine SDK.

With the CL is it possible to use the testing mode on a
remote Rietveld instance too.

[jfrederich, 2014-11-05 22:17:34]

Hello rsc@golang.org, minux@golang.org (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[minux, 2014-11-05 23:01:41]

why test with a remote rietveld instance?

i think we're not supposed to test against the production rietveld.

[jfrederich, 2014-11-05 23:52:53]

On Nov 6, 2014 12:01 AM, "minux" <minux@golang.org> wrote:
>
> why test with a remote rietveld instance?

At the moment the test suite, test.sh, fails with some HTTP 500 errors. But
only on a local Rieveld instance. To proof my suspicion I run it against a
remote instance. That's why.

>
> i think we're not supposed to test against the production rietveld.

I don't run my tests against the production server. I created my own remote
testing instance (https://jfrederich-codereview.appspot.com).

Jens

[rsc, 2014-11-06 00:58:56]

This patch seems too complex. As far as I can tell the only thing you
really need is not to try to use test@example.com. I don't see why tests
can't keep using http instead of https. In any event, please wait until
December. I'd rather not commit anything to the repo right now.

Russ

[jfrederich, 2014-11-06 17:48:45]

On Thu, Nov 6, 2014 at 1:58 AM, Russ Cox <rsc@golang.org> wrote:
> This patch seems too complex. As far as I can tell the only thing you really
> need is not to try to use test@example.com. I don't see why tests can't keep
> using http instead of https. In any event, please wait until December. I'd
> rather not commit anything to the repo right now.

Complex, maybe. For the remote setup I used the standard App Engine and
standard Rietveld settings. The instance use per default https. So
that's the reason for the CL. I want to replace https with http only
on a local Rietveld instance.

remote testing mode:
  -  disable remote.find("://") check

local testing mode:
  - disable remote.find("://") check
  - use test@example.com
  - replace https with http

Okay, I'll wait until December.

Jens

[rsc, 2014-11-21 20:05:23]

On Thu, Nov 6, 2014 at 12:48 PM, Jens Frederich <jfrederich@gmail.com>
wrote:

> On Thu, Nov 6, 2014 at 1:58 AM, Russ Cox <rsc@golang.org> wrote:
> > This patch seems too complex. As far as I can tell the only thing you
> really
> > need is not to try to use test@example.com. I don't see why tests can't
> keep
> > using http instead of https. In any event, please wait until December.
> I'd
> > rather not commit anything to the repo right now.
>

I'm sorry I couldn't say this at the time.

In December I'm going to delete lib/codereview/codereview.py. You are of
course welcome to keep using it, but we won't be taking any more patches to
it. It is what it is, and it won't be for long.

https://groups.google.com/forum/#!topic/golang-dev/sckirqOWepg

Thanks.
Russ

[gobot, 2014-12-19 05:15:08]

R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/166190043 is best) in the description in your
new CL.

Thanks very much.