Issue 166045: Fixes issue 1154, selectEl.options.selectedIndex.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 166045: Fixes issue 1154, selectEl.options.selectedIndex. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 3 months ago by metaweta

Modified:
16 years, 3 months ago

Reviewers:
Jasvir

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Exposes the selectedIndex property on an options nodelist.

Patch Set 2 : Fixes issue 1154, selectEl.options.selectedIndex. #

Created: 16 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -1 line)			Patch
	M	src/com/google/caja/plugin/domita.js	View	1	2 chunks	+8 lines, -1 line	0 comments	Download
	M	tests/com/google/caja/plugin/domita_test_untrusted.html	View	1	2 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Jasvir

LGTM http://codereview.appspot.com/166045/diff/1/2 File tests/com/google/caja/plugin/domita_test_untrusted.html (right): http://codereview.appspot.com/166045/diff/1/2#newcode464 tests/com/google/caja/plugin/domita_test_untrusted.html:464: <option value="0">0</option> Avoid testcase where value == selectedIndex ...

16 years, 3 months ago (2009-12-04 00:41:56 UTC) #2

metaweta

On 2009/12/04 00:41:56, jasvir wrote: > LGTM > > http://codereview.appspot.com/166045/diff/1/2 > File tests/com/google/caja/plugin/domita_test_untrusted.html (right): > ...

16 years, 3 months ago (2009-12-09 00:40:12 UTC) #3

metaweta

16 years, 3 months ago (2009-12-09 00:53:22 UTC) #4

On 2009/12/09 00:40:12, metaweta wrote:
> On 2009/12/04 00:41:56, jasvir wrote:
> > LGTM
> > 
> > http://codereview.appspot.com/166045/diff/1/2
> > File tests/com/google/caja/plugin/domita_test_untrusted.html (right):
> > 
> > http://codereview.appspot.com/166045/diff/1/2#newcode464
> > tests/com/google/caja/plugin/domita_test_untrusted.html:464: <option
> > value="0">0</option>
> > Avoid testcase where value == selectedIndex to be sure you're not getting a
> > spurious passing test.
> 
> Done.

@3896

Expand All Messages | Collapse All Messages