Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(138)

Issue 165330043: i#1551 Port DynamoRIO to ARM: update instr_shared.c to build for ARM (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by zhaoqin
Modified:
11 years, 5 months ago
Reviewers:
bruening
CC:
dynamorio-devs_googlegroups.com
Base URL:
https://dynamorio.googlecode.com/svn/trunk
Visibility:
Public.

Description

i#1551 Port DynamoRIO to ARM: update instr_shared.c to build for ARM - add INSTR_CREATE_mov(), INSTR_CREATE_load_mm(), INSTR_CREATE_store_mm(), and INSTR_CREATE_jmp_ind_mem(). - add OP_load and OP_store - update instr_shared.c to build for ARM R=bruening@google.com BUG=1551 Committed: https://code.google.com/p/dynamorio/source/detail?r=2937

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -27 lines) Patch
M api/docs/release.dox View 1 chunk +3 lines, -2 lines 0 comments Download
M core/arch/arm/instr_create.h View 2 chunks +41 lines, -0 lines 1 comment Download
M core/arch/arm/opcode.h View 1 chunk +3 lines, -0 lines 1 comment Download
M core/arch/instr_shared.c View 15 chunks +50 lines, -25 lines 0 comments Download
M core/arch/x86/instr_create.h View 1 chunk +35 lines, -0 lines 0 comments Download
M core/arch/x86/opcode.h View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 8
zhaoqin
11 years, 5 months ago (2014-11-02 02:48:12 UTC) #1
bruening
commit msg looks like it has some mistakes: INSTR_CREATE_mov and INSTR_CREATE_load_mm are listed twice
11 years, 5 months ago (2014-11-03 16:56:26 UTC) #2
zhaoqin
On 2014/11/03 16:56:26, bruening wrote: > commit msg looks like it has some mistakes: INSTR_CREATE_mov ...
11 years, 5 months ago (2014-11-03 17:09:05 UTC) #3
bruening
On 2014/11/03 17:09:05, zhaoqin wrote: > On 2014/11/03 16:56:26, bruening wrote: > > commit msg ...
11 years, 5 months ago (2014-11-04 03:14:07 UTC) #4
zhaoqin
On 2014/11/04 03:14:07, bruening wrote: > On 2014/11/03 17:09:05, zhaoqin wrote: > > On 2014/11/03 ...
11 years, 5 months ago (2014-11-04 03:16:44 UTC) #5
bruening
LGTM if the 4 spelling errors in user-facing docs are fixed https://codereview.appspot.com/165330043/diff/1/core/arch/arm/instr_create.h File core/arch/arm/instr_create.h (right): ...
11 years, 5 months ago (2014-11-04 19:20:56 UTC) #6
bruening
LGTM if the 4 spelling errors in user-facing docs are fixed https://codereview.appspot.com/165330043/diff/1/core/arch/arm/instr_create.h File core/arch/arm/instr_create.h (right): ...
11 years, 5 months ago (2014-11-04 19:20:56 UTC) #7
zhaoqin
11 years, 5 months ago (2014-11-04 20:46:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 2937 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b