Issue 1174 - <button>.cloneNode fails on IE

http://code.google.com/p/google-caja/issues/detail?id=1174

ie[67] doesn't let you change a button's type after it's created.
it's the same as the <input> type problem, you have to specify the
type in createElement.  bridal's cloneNode handles <input> correctly
but not <button.


This change fixes constructClone in bridal.js.  I also checked
html4-attributes-defs.json to see whether there are any other nodes
with a "type" or "value" attribute that need to be fixed up.  The only
other ones are PARAM and LI, UK, OL, and disallowed elements like
OBJECT and LINK, none of which are inputs.


Submitted @3898

[MikeSamuel, 2009-12-09 00:25:32]

http://codereview.appspot.com/165098/diff/5/1003
File src/com/google/caja/plugin/bridal.js (right):

http://codereview.appspot.com/165098/diff/5/1003#newcode125
src/com/google/caja/plugin/bridal.js:125: + '" value="' +
escapeAttrib(node.value) + '">';
Changed since button does not have a node.defaultValue since they are not
affected by form.reset().

[felix8a, 2009-12-09 09:22:12]

lgtm

[MikeSamuel, 2009-12-09 22:00:40]

Snapshotted to fix some missing JS files in tests that now fail fast
because bridal asserts its dependency on html.escapeAttrib during
load.

2009/12/9  <felix8a@gmail.com>:
> lgtm
>
> http://codereview.appspot.com/165098
>

[felix8a, 2009-12-09 22:37:31]

ah, yeah.  lgtm.

On 2009/12/09 22:00:40, MikeSamuel wrote:
> Snapshotted to fix some missing JS files in tests that now fail fast
> because bridal asserts its dependency on html.escapeAttrib during
> load.
> 
> 2009/12/9  <felix8a@gmail.com>:
> > lgtm
> >
> > http://codereview.appspot.com/165098
> >
>