code review 165097: When SA_SIGINFO is set, we should use __sa_sigaction on...

When SA_SIGINFO is set, we should use __sa_sigaction on FreeBSD

[dho, 2009-12-08 23:57:48]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review the following change.

[rsc, 2009-12-09 00:51:09]

LGTM

umm, okay but this has no effect on the
generated code, right?


On Tue, Dec 8, 2009 at 15:57,  <devon.odell@gmail.com> wrote:
> Reviewers: rsc,
>
> Message:
> Hello rsc (cc: golang-dev@googlegroups.com),
>
> I'd like you to review the following change.
>
>
> Description:
> When SA_SIGINFO is set, we should use __sa_sigaction on FreeBSD
>
> Please review this at http://codereview.appspot.com/165097
>
> Affected files:
>  M src/pkg/runtime/freebsd/386/signal.c
>  M src/pkg/runtime/freebsd/amd64/signal.c
>
>
> Index: src/pkg/runtime/freebsd/386/signal.c
> ===================================================================
> --- a/src/pkg/runtime/freebsd/386/signal.c
> +++ b/src/pkg/runtime/freebsd/386/signal.c
> @@ -92,9 +92,9 @@
>        for(i = 0; i < NSIG; i++) {
>                if(sigtab[i].flags) {
>                        if(sigtab[i].flags & SigCatch)
> -                               sa.__sigaction_u.__sa_handler = (void*)
> sigtramp;
> +                               sa.__sigaction_u.__sa_sigaction = (void*)
> sigtramp;
>                        else
> -                               sa.__sigaction_u.__sa_handler = (void*)
> sigignore;
> +                               sa.__sigaction_u.__sa_sigaction = (void*)
> sigignore;
>
>                        if(sigtab[i].flags & SigRestart)
>                                sa.sa_flags |= SA_RESTART;
> Index: src/pkg/runtime/freebsd/amd64/signal.c
> ===================================================================
> --- a/src/pkg/runtime/freebsd/amd64/signal.c
> +++ b/src/pkg/runtime/freebsd/amd64/signal.c
> @@ -100,9 +100,9 @@
>        for(i = 0; i < NSIG; i++) {
>                if(sigtab[i].flags) {
>                        if(sigtab[i].flags & SigCatch)
> -                               sa.__sigaction_u.__sa_handler = (void*)
> sigtramp;
> +                               sa.__sigaction_u.__sa_sigaction = (void*)
> sigtramp;
>                        else
> -                               sa.__sigaction_u.__sa_handler = (void*)
> sigignore;
> +                               sa.__sigaction_u.__sa_sigaction = (void*)
> sigignore;
>
>                        if(sigtab[i].flags & SigRestart)
>                                sa.sa_flags |= SA_RESTART;
>
>
>

[dho, 2009-12-09 00:52:40]

2009/12/8 Russ Cox <rsc@golang.org>:
> LGTM
>
> umm, okay but this has no effect on the
> generated code, right?

Nope, just better convention in line with manpages, I guess.

-dho

[rsc, 2009-12-09 02:18:05]

*** Submitted as http://code.google.com/p/go/source/detail?r=3b46cb9510a8 ***

When SA_SIGINFO is set, we should use __sa_sigaction on FreeBSD

R=rsc
CC=golang-dev
http://codereview.appspot.com/165097

Committer: Russ Cox <rsc@golang.org>