Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(382)

Issue 165097: code review 165097: When SA_SIGINFO is set, we should use __sa_sigaction on... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 3 months ago by dho
Modified:
14 years, 3 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

When SA_SIGINFO is set, we should use __sa_sigaction on FreeBSD

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/pkg/runtime/freebsd/386/signal.c View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/freebsd/amd64/signal.c View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
dho
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review the following change.
14 years, 3 months ago (2009-12-08 23:57:48 UTC) #1
rsc
LGTM umm, okay but this has no effect on the generated code, right? On Tue, ...
14 years, 3 months ago (2009-12-09 00:51:09 UTC) #2
dho
2009/12/8 Russ Cox <rsc@golang.org>: > LGTM > > umm, okay but this has no effect ...
14 years, 3 months ago (2009-12-09 00:52:40 UTC) #3
rsc
14 years, 3 months ago (2009-12-09 02:18:05 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=3b46cb9510a8 ***

When SA_SIGINFO is set, we should use __sa_sigaction on FreeBSD

R=rsc
CC=golang-dev
http://codereview.appspot.com/165097

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b