Issue 165057: code review 165057: make Native Client support build again,

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 165057: code review 165057: make Native Client support build again, (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by rsc

Modified:
14 years, 9 months ago

Reviewers:

CC:
r, barry.d.silverman_gmail.com, bss_media.mit.edu, vadim_media.mit.edu

Visibility:
Public.

Description

make Native Client support build again, add README explaining how to try the web demos. Fixes issue 339.

Patch Set 1 : code review 165057: make Native Client support build again, #

Patch Set 2 : code review 165057: make Native Client support build again, #

Patch Set 3 : code review 165057: make Native Client support build again, #

Total comments: 2

Patch Set 4 : code review 165057: make Native Client support build again, #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+158 lines, -20 lines)			Patch
M	src/all-nacl.bash	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	src/make.bash	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/Makefile	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/pkg/exp/4s/4s.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/exp/4s/4s.html	View	1 2 3	1 chunk	+24 lines, -8 lines	0 comments	Download
A	src/pkg/exp/4s/5s.go	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	src/pkg/exp/4s/5s.html	View	1 2 3	1 chunk	+26 lines, -0 lines	0 comments	Download
M	src/pkg/exp/4s/Makefile	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	src/pkg/exp/4s/xs.go	View		1 chunk	+1 line, -1 line	0 comments	Download
A	src/pkg/exp/nacl/README	View		1 chunk	+36 lines, -0 lines	0 comments	Download
M	src/pkg/exp/spacewar/pdp1.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/exp/spacewar/spacewar.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/exp/spacewar/spacewar.html	View	1 2 3	1 chunk	+18 lines, -7 lines	0 comments	Download
M	src/pkg/syscall/syscall_nacl.go	View		2 chunks	+13 lines, -1 line	0 comments	Download
M	src/pkg/syscall/types_nacl.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/ztypes_nacl_386.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/run-nacl	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: barry.d.silverman@gmail.com, bss@media.mit.edu, vadim@media.mit.edu), I'd like you to review the following change.

14 years, 9 months ago (2009-12-04 07:34:20 UTC) #1

LGTM http://codereview.appspot.com/165057/diff/1109/114 File src/pkg/exp/4s/4s.html (right): http://codereview.appspot.com/165057/diff/1109/114#newcode27 src/pkg/exp/4s/4s.html:27: <b>you may need to click on the game ...

14 years, 9 months ago (2009-12-04 17:57:36 UTC) #2

rsc

14 years, 9 months ago (2009-12-04 18:11:36 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=aee3f8de6127 ***

make Native Client support build again,
add README explaining how to try the
web demos.

Fixes issue 339.

R=r
CC=barry.d.silverman, bss, vadim
http://codereview.appspot.com/165057

Expand All Messages | Collapse All Messages