Issue 164540045: Fixes ibus_engine_update_lookup_table_fast method

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 164540045: Fixes ibus_engine_update_lookup_table_fast method (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by Peng Wu

Modified:
9 years, 5 months ago

Reviewers:
shawn.p.huang, fujiwara, Peng

CC:
shawn.p.huang_gmail.com

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Fixes ibus_engine_update_lookup_table_fast method gnome shell needs the previous page and next page to correctly show the page up/down arrows, send three pages instead of one page. URL: https://bugzilla.gnome.org/show_bug.cgi?id=703020 BUG=

Patch Set 1 #

Patch Set 2 #

Total comments: 1

Patch Set 3 : #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -5 lines)			Patch
	M	src/ibusengine.c	View	1 2	2 chunks	+22 lines, -5 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Peng Wu

Please use the below patch of ibus-libpinyin to test this fix. https://github.com/epico/ibus-libpinyin/commit/82b89ae4b01f353664a44e833829f1633ffdfdd2

9 years, 6 months ago (2014-11-05 07:09:14 UTC) #1

fujiwara

LGTM. Please add a comment about the hard-coded '3' in the source file, which mean ...

9 years, 5 months ago (2014-11-06 10:35:32 UTC) #2

Peng

lgtm with a comment https://codereview.appspot.com/164540045/diff/20001/src/ibusengine.c File src/ibusengine.c (right): https://codereview.appspot.com/164540045/diff/20001/src/ibusengine.c#newcode1456 src/ibusengine.c:1456: ibus_lookup_table_append_candidate (new_table, ibus_lookup_table_get_candidate (table, i)); ...

9 years, 5 months ago (2014-11-10 16:20:13 UTC) #4

code formatted.

Expand All Messages | Collapse All Messages