Issue 164080: Prevent NullPointer exception

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 164080: Prevent NullPointer exception

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 2 months ago by zhoresh

Modified:
16 years, 2 months ago

Reviewers:
johnfargo, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Description

The Proxy servlet generate a null pointer exception if there is no url parameter. (ProxyHandler.java:146 - HttpRequest is null) The code should generate an error page using GadgetException

Patch Set 1 #

Created: 16 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java	View		1 chunk	+4 lines, -0 lines	0 comments	Download
		java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyHandlerTest.java	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Looks great Ziv - patch committed, thanks!

Expand All Messages | Collapse All Messages