Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(44)

Issue 164048: Fix the continuous build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 6 months ago by Jasvir
Modified:
16 years, 6 months ago
Reviewers:
MikeSamuel
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The continuous build script was breaking because: * the output format of emma coverage changed * malformed javadoc would cause java/doc/index.html not to be created which caused outputTree to exit

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix the continuous build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M src/com/google/caja/lang/css/CssPropertyPatterns.java View 1 1 chunk +8 lines, -7 lines 0 comments Download
M tools/dashboard/dashboard.pl View 1 3 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 4
Jasvir
16 years, 6 months ago (2009-11-30 22:28:08 UTC) #1
MikeSamuel
http://codereview.appspot.com/164048/diff/1/3 File src/com/google/caja/lang/css/CssPropertyPatterns.java (right): http://codereview.appspot.com/164048/diff/1/3#newcode153 src/com/google/caja/lang/css/CssPropertyPatterns.java:153: * Set of properties accessible on computed style of ...
16 years, 6 months ago (2009-11-30 23:02:58 UTC) #2
Jasvir
http://codereview.appspot.com/164048/diff/1/3 File src/com/google/caja/lang/css/CssPropertyPatterns.java (right): http://codereview.appspot.com/164048/diff/1/3#newcode153 src/com/google/caja/lang/css/CssPropertyPatterns.java:153: * Set of properties accessible on computed style of ...
16 years, 6 months ago (2009-12-01 00:43:18 UTC) #3
MikeSamuel
16 years, 6 months ago (2009-12-01 01:25:22 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b