Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(42)

Issue 164020043: Addition of MPDU aggregation

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by gbadawy
Modified:
7 years, 8 months ago
Reviewers:
Nazarius
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Addition of MPDU aggregation

Patch Set 1 #

Patch Set 2 : Corrected some compiling errors after enabling tests and examples #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2479 lines, -162 lines) Patch
A examples/wireless/simple-wifi-mpdu-aggregation.cc View 1 chunk +223 lines, -0 lines 0 comments Download
M src/mesh/model/dot11s/airtime-metric.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/wifi/examples/wifi-phy-test.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/wifi/helper/qos-wifi-mac-helper.h View 2 chunks +24 lines, -0 lines 0 comments Download
M src/wifi/helper/qos-wifi-mac-helper.cc View 3 chunks +22 lines, -1 line 0 comments Download
A src/wifi/model/ampdu-subframe-header.h View 1 chunk +61 lines, -0 lines 0 comments Download
A src/wifi/model/ampdu-subframe-header.cc View 1 chunk +118 lines, -0 lines 0 comments Download
A src/wifi/model/ampdu-tag.h View 1 chunk +71 lines, -0 lines 0 comments Download
A src/wifi/model/ampdu-tag.cc View 1 chunk +104 lines, -0 lines 0 comments Download
M src/wifi/model/block-ack-agreement.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/wifi/model/block-ack-agreement.cc View 1 chunk +10 lines, -1 line 0 comments Download
M src/wifi/model/block-ack-cache.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/wifi/model/block-ack-cache.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/wifi/model/block-ack-manager.h View 6 chunks +32 lines, -1 line 0 comments Download
M src/wifi/model/block-ack-manager.cc View 12 chunks +229 lines, -35 lines 0 comments Download
M src/wifi/model/edca-txop-n.h View 6 chunks +21 lines, -2 lines 0 comments Download
M src/wifi/model/edca-txop-n.cc View 17 chunks +225 lines, -19 lines 0 comments Download
M src/wifi/model/mac-low.h View 12 chunks +105 lines, -4 lines 0 comments Download
M src/wifi/model/mac-low.cc View 43 chunks +628 lines, -50 lines 0 comments Download
M src/wifi/model/mac-tx-middle.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/wifi/model/mac-tx-middle.cc View 1 chunk +25 lines, -1 line 0 comments Download
M src/wifi/model/minstrel-wifi-manager.cc View 1 chunk +1 line, -1 line 0 comments Download
A src/wifi/model/mpdu-aggregator.h View 1 chunk +61 lines, -0 lines 0 comments Download
A src/wifi/model/mpdu-aggregator.cc View 1 chunk +77 lines, -0 lines 0 comments Download
A src/wifi/model/mpdu-standard-aggregator.h View 1 chunk +62 lines, -0 lines 0 comments Download
A src/wifi/model/mpdu-standard-aggregator.cc View 1 chunk +155 lines, -0 lines 0 comments Download
M src/wifi/model/wifi-mac-queue.h View 2 chunks +12 lines, -1 line 0 comments Download
M src/wifi/model/wifi-mac-queue.cc View 3 chunks +26 lines, -1 line 0 comments Download
M src/wifi/model/wifi-phy.h View 4 chunks +9 lines, -4 lines 0 comments Download
M src/wifi/model/wifi-phy.cc View 10 chunks +69 lines, -13 lines 0 comments Download
M src/wifi/model/wifi-preamble.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/wifi/model/yans-wifi-channel.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/wifi/model/yans-wifi-channel.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M src/wifi/model/yans-wifi-phy.h View 3 chunks +6 lines, -2 lines 0 comments Download
M src/wifi/model/yans-wifi-phy.cc View 9 chunks +57 lines, -10 lines 0 comments Download
M src/wifi/test/tx-duration-test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/wifi/wscript View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Nazarius
Hi all, I was testing MPDU aggregation and HT rates in NS-3.21 using above patch. ...
7 years, 8 months ago (2014-12-17 10:28:21 UTC) #1
gbadawy
Hi Nazar, You need to set ChannelBonding to true for 40MHz data rates. Also make ...
7 years, 8 months ago (2014-12-17 14:00:16 UTC) #2
Nazarius
7 years, 8 months ago (2014-12-18 02:50:22 UTC) #3
Hi Ghada!

Thanks for the point! I didn't know that we have to explicitly tell about
channel bonding in the scripts.
Now I have this kind of result:

No.	DataRate	Throughput
0	6.5		5.286
1	13		9.186
2	19.5		12.234
3	26		14.64
4	39		18.276
5	52		20.85
6	58.5		10.992
7	65		22.71
8	7.2		5.76
9	14.4		9.936
10	21.7		13.14
11	28.9		15.654
12	43.3		19.29
13	57.8		21.834
14	65		22.944
15	72.2		23.73
16	13.5		9.534
17	27		15.18
18	40.5		9.528
19	54		21.636
20	81		25.158
21	108		27.318
22	121.5		28.428
23	135		28.68
24	15		10.344
25	30		16.26
26	45		19.992
27	60		22.608
28	90		26.04
29	120		28.182
30	135		14.67
31	150		29.736

There seem to be some problem with OfdmRate135MbpsBW40MHzShGi rate since it's
producing only half of the throughput that it is supposed to yield.

Thanks,
Nazar

On 2014/12/17 14:00:16, gbadawy wrote:
> Hi Nazar,
> You need to set ChannelBonding to true for 40MHz data rates. Also make sure
> you are setting ShortGuardInterval to true for data rates that use short
> guard interval
> 
> Regards,
> Ghada
> 
> On Wed, Dec 17, 2014 at 5:28 AM, <mailto:seytnazarovsho@gmail.com> wrote:
> >
> > Hi all,
> > I was testing MPDU aggregation and HT rates in NS-3.21 using above
> > patch. Surprisingly 40MHz rates are giving null throughput in my tests.
> > Here is the output of the modified ht-wifi-network script
> > (https://www.sendspace.com/file/txfep2) that tests all available 1X1
> > MIMO rates:
> >
> > No.     DataRate        Throughput
> > 0       6.5             5.286
> > 1       13              9.186
> > 2       19.5            12.234
> > 3       26              14.64
> > 4       39              18.276
> > 5       52              20.85
> > 6       58.5            10.992
> > 7       65              22.71
> > 8       7.2             5.76
> > 9       14.4            9.936
> > 10      21.7            13.14
> > 11      28.9            15.654
> > 12      43.3            19.29
> > 13      57.8            21.834
> > 14      65              0
> > 15      72.2            23.73
> > 16      13.5            0
> > 17      27              0
> > 18      40.5            0
> > 19      54              0
> > 20      81              0
> > 21      108             0
> > 22      121.5           0
> > 23      135             0
> > 24      15              0
> > 25      30              0
> > 26      45              0
> > 27      60              0
> > 28      90              0
> > 29      120             0
> > 30      135             0
> > 31      150             0
> >
> > Does anyone have any clue for it?
> >
> > Thanks,
> > Nazar.
> >
> > https://codereview.appspot.com/164020043/
> >
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b