Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(21)

Issue 163058: code review 163058: Integrated feedback by Ken. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by gri
Modified:
9 years, 6 months ago
Reviewers:
CC:
iant, rsc, r, ken2
Visibility:
Public.

Description

Integrated feedback by Ken. Easy stuff in this round, more to come.

Patch Set 1 #

Patch Set 2 : code review 163058: Integrated feedbacb by Ken. #

Total comments: 14

Patch Set 3 : code review 163058: Integrated feedback by Ken. #

Patch Set 4 : code review 163058: Integrated feedback by Ken. #

Patch Set 5 : code review 163058: Integrated feedback by Ken. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -39 lines) Patch
M doc/go_spec.html View 1 2 3 4 23 chunks +37 lines, -39 lines 0 comments Download

Messages

Total messages: 9
gri
Hello iant, rsc, r, ken2 (cc: gri), I'd like you to review the following change.
9 years, 6 months ago (2009-12-01 22:56:04 UTC) #1
rsc
LGTM http://codereview.appspot.com/163058/diff/3/4 File doc/go_spec.html (right): http://codereview.appspot.com/163058/diff/3/4#newcode542 doc/go_spec.html:542: The value of an n-bit integer is n ...
9 years, 6 months ago (2009-12-01 23:18:57 UTC) #2
r
http://codereview.appspot.com/163058/diff/3/4 File doc/go_spec.html (right): http://codereview.appspot.com/163058/diff/3/4#newcode352 doc/go_spec.html:352: and two-digit hexadecimal (<code>\xnn</code>) escapes represent individual i prefer ...
9 years, 6 months ago (2009-12-01 23:25:54 UTC) #3
r
LGTM
9 years, 6 months ago (2009-12-01 23:26:03 UTC) #4
gri
PTAL. http://codereview.appspot.com/163058/diff/3/4 File doc/go_spec.html (right): http://codereview.appspot.com/163058/diff/3/4#newcode352 doc/go_spec.html:352: and two-digit hexadecimal (<code>\xnn</code>) escapes represent individual On ...
9 years, 6 months ago (2009-12-01 23:41:27 UTC) #5
rsc
> technically this is not correct: two's complement is a specific value > (see the ...
9 years, 6 months ago (2009-12-02 00:00:24 UTC) #6
gri
sounds good. On Tuesday, December 1, 2009, Russ Cox <rsc@golang.org> wrote: >> technically this is ...
9 years, 6 months ago (2009-12-02 00:14:58 UTC) #7
gri
*** Submitted as http://code.google.com/p/go/source/detail?r=e6cf652c263f *** Integrated feedback by Ken. Easy stuff in this round, more ...
9 years, 6 months ago (2009-12-02 00:15:55 UTC) #8
rsc
9 years, 6 months ago (2009-12-02 09:51:42 UTC) #9

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b