Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4891)

Issue 162630043: Issue 482: AuthorizeAsync - browser will not self-close (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by jmcgrew
Modified:
5 years ago
Reviewers:
peleyal, LindaL
Base URL:
https://google-api-dotnet-client.googlecode.com/hg/
Visibility:
Public.

Description

OAuth redirects to a page served by a local HTTP server. The server collects the authentication data and serves a page that attempts to close the browser window, but it fails with a JavaScript error.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Just change the message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Src/GoogleApis.Auth.DotNet4/OAuth2/LocalServerCodeReceiver.cs View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8
jmcgrew
5 years, 1 month ago (2014-11-01 00:35:32 UTC) #1
peleyal
Beside my other comment, please change the hear to: "Issue 482: AuthorizeAsync - browser will ...
5 years, 1 month ago (2014-11-01 23:41:01 UTC) #2
jmcgrew
On 2014/11/01 23:41:01, peleyal wrote: > This code works before (or still working for Windows ...
5 years, 1 month ago (2014-11-03 19:49:42 UTC) #3
peleyal
We talked on that offline. I'll support however you decide to continue from here. Thanks, ...
5 years, 1 month ago (2014-11-04 21:01:59 UTC) #4
jmcgrew
Restored the JavaScript and just changed the message to indicate that the window may need ...
5 years, 1 month ago (2014-11-15 01:10:24 UTC) #5
peleyal
LGTM sir :)
5 years ago (2014-11-19 22:07:26 UTC) #6
LindaL
On 2014/11/19 22:07:26, peleyal wrote: > LGTM sir :) The bug is also in windows ...
5 years ago (2014-12-01 14:58:17 UTC) #7
jmcgrew
5 years ago (2014-12-02 07:31:04 UTC) #8
See the discussion at
https://code.google.com/p/google-api-dotnet-client/issues/detail?id=482 -
this appears to be a limitation of modern browsers. IMO an embedded browser
would be the cleanest alternative, but also the least portable.


Jesse McGrew | Apps Capacity SRE | jmcgrew@google.com | 650-253-6516

On Mon, Dec 1, 2014 at 6:58 AM, <laurly71@gmail.com> wrote:

> On 2014/11/19 22:07:26, peleyal wrote:
>
>> LGTM sir :)
>>
>
> The bug is also in windows 7.  Having a browser window in the project
> and then loading it there does work, but its not as clean. It would be
> nice if we could get this working again.
>
> https://codereview.appspot.com/162630043/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b