Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(20)

Issue 1626041: [Shindig-1085] stylesheets with different media attribute shouldn't be merged (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 10 months ago by henry.saputra
Modified:
15 years, 7 months ago
Reviewers:
dev-remailer, mat.mannion
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Proposed fix for SHINDIG-1085 stylesheets with different media attribute shouldn't be merged. Modify HTMLContentRewrtiter and the unit test file to concat the link tags based on media attribute. Add some code cleanup for lines > 100

Patch Set 1 #

Patch Set 2 : Wrap > 100 line #

Patch Set 3 : Simplify logic since Element.getAttribute return empty String if the attribute value is not there #

Patch Set 4 : Change local file name #

Patch Set 5 : Rearrange imports #

Total comments: 1

Patch Set 6 : Add check for link tag based on Mat Mannion review #

Messages

Total messages: 3
henry.saputra
Proposed fix for [Shindig-1085] stylesheets with different media attribute shouldn't be merged. Concatenate stylesheet links ...
15 years, 10 months ago (2010-06-09 02:51:38 UTC) #1
mat.mannion
lgtm http://codereview.appspot.com/1626041/diff/13001/14004 File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/old/HTMLContentRewriter.java (right): http://codereview.appspot.com/1626041/diff/13001/14004#newcode149 java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/old/HTMLContentRewriter.java:149: if (!feature.getIncludedTags().contains("style")) { We need to check whether ...
15 years, 10 months ago (2010-06-11 17:02:47 UTC) #2
henry.saputra
15 years, 10 months ago (2010-06-11 17:36:59 UTC) #3
Add check for "link" tag if its in the content rewrite include tags based on
review from Mat Mannion.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b