Proposed fix for SHINDIG-1085 stylesheets with different media attribute shouldn't be merged.
Modify HTMLContentRewrtiter and the unit test file to concat the link tags based on media attribute.
Add some code cleanup for lines > 100
Proposed fix for [Shindig-1085] stylesheets with different media attribute shouldn't be merged. Concatenate stylesheet links ...
15 years, 10 months ago
(2010-06-09 02:51:38 UTC)
#1
Proposed fix for [Shindig-1085] stylesheets with different media attribute
shouldn't be merged.
Concatenate stylesheet links for each media type instead of for all links.
Update the test file to test this scenario.
Review is greatly appreciated.
- Henry
lgtm http://codereview.appspot.com/1626041/diff/13001/14004 File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/old/HTMLContentRewriter.java (right): http://codereview.appspot.com/1626041/diff/13001/14004#newcode149 java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/old/HTMLContentRewriter.java:149: if (!feature.getIncludedTags().contains("style")) { We need to check whether ...
15 years, 10 months ago
(2010-06-11 17:02:47 UTC)
#2
Issue 1626041: [Shindig-1085] stylesheets with different media attribute shouldn't be merged
(Closed)
Created 15 years, 10 months ago by henry.saputra
Modified 15 years, 7 months ago
Reviewers: dev-remailer_shindig.apache.org, mat.mannion
Base URL: http://svn.apache.org/repos/asf/shindig/trunk/
Comments: 1