Fix example Makefile to avoid $GOROOT in case it has spaces.

Fix example Makefile to avoid $GOROOT in case it has spaces.

[rsc, 2009-11-30 04:51:13]

> +Use relative path instead of $(GOROOT)/src to avoid an issue with a
> directory which include spaces.

Please rephrase this:

For packages to be installed in the Go tree, use a relative
path instead of $(GOROOT)/src, so that make will work
correctly even if $(GOROOT) contains spaces.

Thanks.

[ukai, 2009-11-30 04:55:09]

On 2009/11/30 04:51:13, rsc wrote:
> > +Use relative path instead of $(GOROOT)/src to avoid an issue with a
> > directory which include spaces.
> 
> Please rephrase this:
> 
> For packages to be installed in the Go tree, use a relative
> path instead of $(GOROOT)/src, so that make will work
> correctly even if $(GOROOT) contains spaces.
> 
> Thanks.
> 
Thanks for review!
Fixed.

[sergio (larces), 2009-11-30 04:57:20]

On 2009/11/30 04:51:13, rsc wrote:
> > +Use relative path instead of $(GOROOT)/src to avoid an issue with a
> > directory which include spaces.
> 
> Please rephrase this:
> 
> For packages to be installed in the Go tree, use a relative
> path instead of $(GOROOT)/src, so that make will work
> correctly even if $(GOROOT) contains spaces.
> 
> Thanks.
> 

We still don't have an elegant solution for off-tree packages when $(GOROOT)
contains spaces, as in this case one can't use relative paths or $(GOROOT)/src
directly =/

[sergio (larces), 2009-11-30 05:03:10]

On 2009/11/30 04:57:20, sergio wrote:
> We still don't have an elegant solution for off-tree packages when $(GOROOT)
> contains spaces, as in this case one can't use relative paths or $(GOROOT)/src
> directly =/

And by off-tree packages I meant packages we are compiling outside the go tree.
if we manage to include Make.pkg it would be installed with the other packages,
in the end, by make install.

How about having in there (contribute.html) an example on how to proceed with
this case as well?

[ukai, 2009-11-30 05:11:01]

On 2009/11/30 05:03:10, sergio wrote:
> On 2009/11/30 04:57:20, sergio wrote:
> > We still don't have an elegant solution for off-tree packages when $(GOROOT)
> > contains spaces, as in this case one can't use relative paths or
$(GOROOT)/src
> > directly =/
> 
> And by off-tree packages I meant packages we are compiling outside the go
tree.
> if we manage to include Make.pkg it would be installed with the other
packages,
> in the end, by make install.
> 
> How about having in there (contribute.html) an example on how to proceed with
> this case as well?

I think contribute.html explains how to contribute the code, so off-tree package
is out of focus of this document.
It would be nice we have another document to create own off-tree package (or add
the topic in effective_go.html?)

[rsc, 2009-11-30 05:12:24]

http://codereview.appspot.com/162058/diff/1002/1003
File doc/contribute.html (right):

http://codereview.appspot.com/162058/diff/1002/1003#newcode80
doc/contribute.html:80: $(GOROOT)/src/Make.$(GOARCH) and $(GOROOT)/src/Make.pkg,
I missed this the last time around, sorry.
Please put <code>...</code> brackets around
the two file names here and also the 
$(GOROOT)/src and $(GOROOT) a few lines later.

[rsc, 2009-11-30 05:14:06]

> And by off-tree packages I meant packages we are compiling outside the
> go tree. if we manage to include Make.pkg it would be installed with the
> other packages, in the end, by make install.
>
> How about having in there (contribute.html) an example on how to proceed
> with this case as well?

Thanks but no thanks.

I'm willing to meet people with spaces halfway
so that they can play with Go, but once they are trying
to develop packages in a side directory using
make to get at the standard Go paths, that seems
like the right time for them to move $GOROOT so
that it doesn't have spaces anymore.

When we manage to get away from make
it will be easier to accommodate oddities
like spaces in file names.  For people motivated
enough to be writing their own packages, it's
easy to make a symlink that doesn't have
a space in it.

Russ

[sergio (larces), 2009-11-30 05:15:31]

On 2009/11/30 05:14:06, rsc wrote:
> > And by off-tree packages I meant packages we are compiling outside the
> > go tree. if we manage to include Make.pkg it would be installed with the
> > other packages, in the end, by make install.
> >
> > How about having in there (contribute.html) an example on how to proceed
> > with this case as well?
> 
> Thanks but no thanks.
> 
> I'm willing to meet people with spaces halfway
> so that they can play with Go, but once they are trying
> to develop packages in a side directory using
> make to get at the standard Go paths, that seems
> like the right time for them to move $GOROOT so
> that it doesn't have spaces anymore.
> 
> When we manage to get away from make
> it will be easier to accommodate oddities
> like spaces in file names.  For people motivated
> enough to be writing their own packages, it's
> easy to make a symlink that doesn't have
> a space in it.
> 
> Russ
> 

heh you and ukai are right.

thanks,
sergio

[ukai, 2009-11-30 05:16:00]

http://codereview.appspot.com/162058/diff/1002/1003
File doc/contribute.html (right):

http://codereview.appspot.com/162058/diff/1002/1003#newcode80
doc/contribute.html:80: $(GOROOT)/src/Make.$(GOARCH) and $(GOROOT)/src/Make.pkg,
On 2009/11/30 05:12:24, rsc wrote:
> I missed this the last time around, sorry.
> Please put <code>...</code> brackets around
> the two file names here and also the 
> $(GOROOT)/src and $(GOROOT) a few lines later.
> 

Done.

[rsc, 2009-11-30 05:22:09]

*** Submitted as http://code.google.com/p/go/source/detail?r=6ccdfb494664 ***

Fix example Makefile to avoid $GOROOT in case it has spaces.

R=rsc, sergio
http://codereview.appspot.com/162058

Committer: Russ Cox <rsc@golang.org>