Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(993)

Issue 162057: code review 162057: websocket: avoid $GOROOT in case it has spaces (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 5 months ago by rsc
Modified:
14 years, 5 months ago
Reviewers:
CC:
r, ukai, sergio (larces)
Visibility:
Public.

Description

websocket: avoid $GOROOT in case it has spaces Fixes issue 115.

Patch Set 1 #

Patch Set 2 : code review 162057: websocket: avoid $GOROOT in case it has spaces #

Patch Set 3 : code review 162057: websocket: avoid $GOROOT in case it has spaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/pkg/websocket/Makefile View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello r, ukai (cc: sergio), I'd like you to review the following change.
14 years, 5 months ago (2009-11-30 02:38:01 UTC) #1
sergio (larces)
LGTM.
14 years, 5 months ago (2009-11-30 02:49:47 UTC) #2
ukai
LGTM
14 years, 5 months ago (2009-11-30 03:49:48 UTC) #3
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=106104787b73 *** websocket: avoid $GOROOT in case it has spaces Fixes issue ...
14 years, 5 months ago (2009-11-30 04:30:08 UTC) #4
rsc
14 years, 5 months ago (2009-12-02 09:53:31 UTC) #5

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b