Issue 1620042: code review 1620042: misc cleanup: gofmt + &x -> x[0:] conversion

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1620042: code review 1620042: misc cleanup: gofmt + &x -> x[0:] conversion (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by rsc

Modified:
14 years, 9 months ago

Reviewers:

CC:
gri, golang-dev

Visibility:
Public.

Description

misc cleanup: gofmt + &x -> x[0:] conversion

Patch Set 1 #

Patch Set 2 : code review 1620042: misc cleanup: gofmt + &x -> x[0:] conversion #

Patch Set 3 : code review 1620042: misc cleanup: gofmt + &x -> x[0:] conversion #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+149 lines, -141 lines)			Patch
M	src/pkg/debug/macho/file.go	View	5 chunks	+9 lines, -9 lines	0 comments	Download
M	src/pkg/debug/proc/regs_linux_386.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/http/triv.go	View	5 chunks	+11 lines, -4 lines	0 comments	Download
M	src/pkg/json/stream_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/net/iprawsock.go	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/net/tcpsock.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/net/udpsock.go	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	test/copy.go	View	8 chunks	+105 lines, -105 lines	0 comments	Download
M	test/fixedbugs/bug102.go	View	1 chunk	+8 lines, -7 lines	0 comments	Download
M	test/ken/string.go	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello gri (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 9 months ago (2010-06-09 00:19:01 UTC) #1

gri

LGTM On Tue, Jun 8, 2010 at 5:19 PM, <rsc@golang.org> wrote: > Reviewers: gri, > ...

14 years, 9 months ago (2010-06-09 00:24:41 UTC) #2

rsc

14 years, 9 months ago (2010-06-09 00:52:07 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=53b95ea3fb83 ***

misc cleanup: gofmt + &x -> x[0:] conversion

R=gri
CC=golang-dev
http://codereview.appspot.com/1620042

Expand All Messages | Collapse All Messages