UAN Framework project (GSoC)

[socket, 2010-06-26 09:51:53]

http://codereview.appspot.com/1618042/diff/2001/3008
File src/mobility/wscript (right):

http://codereview.appspot.com/1618042/diff/2001/3008#newcode26
src/mobility/wscript:26: 'waypoint-helper-mobility-model.cc',
This should not have been here, it is an ongoing modification

http://codereview.appspot.com/1618042/diff/2001/3008#newcode51
src/mobility/wscript:51: 'waypoint-helper-mobility-model.h',
This should not have been here, it is an ongoing modification

[lentracy, 2010-07-13 04:07:39]

A couple minor comments.

http://codereview.appspot.com/1618042/diff/17001/18006
File src/mobility/uan-glider-mobility-model.cc (right):

http://codereview.appspot.com/1618042/diff/17001/18006#newcode40
src/mobility/uan-glider-mobility-model.cc:40: //    .AddAttribute ("Bounds",
"Bounds of the area to cruise.",
What is your plan for this attribute?

http://codereview.appspot.com/1618042/diff/17001/18007
File src/mobility/uan-remus-mobility-model.cc (right):

http://codereview.appspot.com/1618042/diff/17001/18007#newcode261
src/mobility/uan-remus-mobility-model.cc:261: UanRemusMobilityModel::DoSubmerge
(double depth)
Maybe it would be best to pass deltaDepth as the argument here instead of an
absolute depth.  Another function perhaps useful to the interface would be
something along the lines of SetDepth or MakeDepth in which an absolute depth
could be passed between 0 and m_maxDepth.  Just a thought

[socket, 2010-08-05 12:07:33]

Review moved to http://codereview.appspot.com/1743057


On 2010/07/13 04:07:39, lentracy wrote:
> A couple minor comments.
> 
> http://codereview.appspot.com/1618042/diff/17001/18006
> File src/mobility/uan-glider-mobility-model.cc (right):
> 
> http://codereview.appspot.com/1618042/diff/17001/18006#newcode40
> src/mobility/uan-glider-mobility-model.cc:40: //    .AddAttribute ("Bounds",
> "Bounds of the area to cruise.",
> What is your plan for this attribute?
> 
> http://codereview.appspot.com/1618042/diff/17001/18007
> File src/mobility/uan-remus-mobility-model.cc (right):
> 
> http://codereview.appspot.com/1618042/diff/17001/18007#newcode261
> src/mobility/uan-remus-mobility-model.cc:261:
UanRemusMobilityModel::DoSubmerge
> (double depth)
> Maybe it would be best to pass deltaDepth as the argument here instead of an
> absolute depth.  Another function perhaps useful to the interface would be
> something along the lines of SetDepth or MakeDepth in which an absolute depth
> could be passed between 0 and m_maxDepth.  Just a thought