code review 1616041: fix build

fix build

[rsc, 2010-06-08 23:14:17]

Hello gri (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-06-08 23:14:26]

*** Submitted as http://code.google.com/p/go/source/detail?r=d4e79a732a34 ***

fix build

R=gri
CC=golang-dev
http://codereview.appspot.com/1616041

[gri, 2010-06-08 23:15:53]

LGTM

On Tue, Jun 8, 2010 at 4:14 PM, <rsc@golang.org> wrote:

> Reviewers: gri,
>
> Message:
> Hello gri (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> fix build
>
> Please review this at http://codereview.appspot.com/1616041/show
>
> Affected files:
>  M test/bugs/bug285.go
>  M test/golden.out
>
>
> Index: test/bugs/bug285.go
> ===================================================================
> --- a/test/bugs/bug285.go
> +++ b/test/bugs/bug285.go
> @@ -1,4 +1,4 @@
> -// $G $D/$F.go && $L $F.go && ./$A.out
> +// $G $D/$F.go && $L $F.go && ./$A.out || echo BUG: bug285
>
>  // Copyright 2010 The Go Authors.  All rights reserved.
>  // Use of this source code is governed by a BSD-style
> Index: test/golden.out
> ===================================================================
> --- a/test/golden.out
> +++ b/test/golden.out
> @@ -194,31 +194,32 @@
>  errchk: bugs/bug284.go:74: missing expected error: 'cannot'
>  errchk: bugs/bug284.go:75: missing expected error: 'cannot'
>  errchk: bugs/bug284.go:76: missing expected error: 'cannot'
> -errchk: bugs/bug284.go:95: missing expected error: 'cannot'
> -errchk: bugs/bug284.go:97: missing expected error: 'cannot'
> -errchk: bugs/bug284.go:107: missing expected error: 'cannot'
> -errchk: bugs/bug284.go:110: missing expected error: 'cannot'
> +errchk: bugs/bug284.go:96: missing expected error: 'cannot'
> +errchk: bugs/bug284.go:99: missing expected error: 'cannot'
> +errchk: bugs/bug284.go:101: missing expected error: 'cannot'
>  errchk: bugs/bug284.go:111: missing expected error: 'cannot'
> -errchk: bugs/bug284.go:112: missing expected error: 'cannot'
> -errchk: bugs/bug284.go:130: missing expected error: 'cannot'
> -errchk: bugs/bug284.go:133: missing expected error: 'cannot'
> -errchk: bugs/bug284.go:134: missing expected error: 'cannot'
> -errchk: bugs/bug284.go:135: missing expected error: 'cannot'
> -errchk: bugs/bug284.go:145: missing expected error: 'cannot'
> -errchk: bugs/bug284.go:148: missing expected error: 'cannot'
> +errchk: bugs/bug284.go:114: missing expected error: 'cannot'
> +errchk: bugs/bug284.go:115: missing expected error: 'cannot'
> +errchk: bugs/bug284.go:116: missing expected error: 'cannot'
> +errchk: bugs/bug284.go:134: missing expected error: 'cannot|need type
> assertion'
> +errchk: bugs/bug284.go:137: missing expected error: 'cannot|need type
> assertion'
> +errchk: bugs/bug284.go:138: missing expected error: 'cannot|need type
> assertion'
> +errchk: bugs/bug284.go:139: missing expected error: 'cannot|need type
> assertion'
>  errchk: bugs/bug284.go:149: missing expected error: 'cannot'
> -errchk: bugs/bug284.go:150: missing expected error: 'cannot'
> -errchk: bugs/bug284.go:160: missing expected error: 'cannot'
> -errchk: bugs/bug284.go:163: missing expected error: 'cannot'
> +errchk: bugs/bug284.go:152: missing expected error: 'cannot'
> +errchk: bugs/bug284.go:153: missing expected error: 'cannot'
> +errchk: bugs/bug284.go:154: missing expected error: 'cannot'
>  errchk: bugs/bug284.go:164: missing expected error: 'cannot'
> -errchk: bugs/bug284.go:165: missing expected error: 'cannot'
> -errchk: bugs/bug284.go:175: missing expected error: 'cannot'
> -errchk: bugs/bug284.go:178: missing expected error: 'cannot'
> +errchk: bugs/bug284.go:167: missing expected error: 'cannot'
> +errchk: bugs/bug284.go:168: missing expected error: 'cannot'
> +errchk: bugs/bug284.go:169: missing expected error: 'cannot'
>  errchk: bugs/bug284.go:179: missing expected error: 'cannot'
> -errchk: bugs/bug284.go:180: missing expected error: 'cannot'
> +errchk: bugs/bug284.go:182: missing expected error: 'cannot'
> +errchk: bugs/bug284.go:183: missing expected error: 'cannot'
> +errchk: bugs/bug284.go:184: missing expected error: 'cannot'
>  errchk: bugs/bug284.go: unmatched error messages:
>  ==================================================
> -bugs/bug284.go:186: internal compiler error: typename ideal
> +bugs/bug284.go:190: internal compiler error: typename ideal
>  ==================================================
>
>  =========== bugs/bug285.go
> @@ -233,4 +234,4 @@
>  bugs/bug285.go:94: invalid map index false - need type I1
>  bugs/bug285.go:95: invalid map index 17 - need type I1
>  bugs/bug285.go:95: too many errors
> -BUG: should compile
> +BUG: bug285
>
>
>