Issue 1613041: code review 1613041: bug285: delete invalid map assignment

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1613041: code review 1613041: bug285: delete invalid map assignment (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by rsc

Modified:
14 years, 9 months ago

Reviewers:

CC:
gri, golang-dev

Visibility:
Public.

Description

bug285: delete invalid map assignment *T2 implements I2, but T2 does not.

Patch Set 2 : code review 1613041: bug285: delete invalid map assignment #

Total comments: 2

Patch Set 3 : code review 1613041: bug285: delete invalid map assignment #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	test/bugs/bug285.go	View	2	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello gri (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 9 months ago (2010-06-08 22:35:40 UTC) #1

gri

LGTM http://codereview.appspot.com/1613041/diff/2001/3001 File test/bugs/bug285.go (right): http://codereview.appspot.com/1613041/diff/2001/3001#newcode98 test/bugs/bug285.go:98: var t2 T2 is t2 still used? http://codereview.appspot.com/1613041/diff/2001/3001#newcode103 ...

14 years, 9 months ago (2010-06-08 22:49:14 UTC) #2

rsc

> http://codereview.appspot.com/1613041/diff/2001/3001#newcode98 > test/bugs/bug285.go:98: var t2 T2 > is t2 still used? gone. > http://codereview.appspot.com/1613041/diff/2001/3001#newcode103 ...

14 years, 9 months ago (2010-06-08 22:50:27 UTC) #3

rsc

14 years, 9 months ago (2010-06-08 22:51:09 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=9b78bc0fdf00 ***

bug285: delete invalid map assignment

*T2 implements I2, but T2 does not.

R=gri
CC=golang-dev
http://codereview.appspot.com/1613041

Expand All Messages | Collapse All Messages