Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(144)

Issue 1606041: Fixing Small Bug in MutableContent (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 9 months ago by gagan.goku
Modified:
15 years, 9 months ago
Reviewers:
johnfargo, zhoresh, shindig.remailer, mat.mannion
CC:
anupama.dutta, pradnya, vikaas.arora, sridhar.sundaram_gmail.com, cool-shindig-committers_googlegroups.com
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Fixing Small Bug in MutableContent when both contentBytes and contentSource are null. We are serializing the document but not using the serialized version :)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java View 6 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 5
zhoresh
lgtm, great catch! I will commit it.
15 years, 9 months ago (2010-06-10 01:34:21 UTC) #1
zhoresh
Submitted as r953197
15 years, 9 months ago (2010-06-10 01:56:19 UTC) #2
gagan.goku
On 2010/06/10 01:56:19, zhoresh wrote: > Submitted as r953197 Thanks Ziv
15 years, 9 months ago (2010-06-11 06:19:12 UTC) #3
mat.mannion
On 2010/06/11 06:19:12, gagan.goku wrote: > On 2010/06/10 01:56:19, zhoresh wrote: > > Submitted as ...
15 years, 9 months ago (2010-06-11 08:10:03 UTC) #4
gagan.goku
15 years, 9 months ago (2010-06-13 05:41:29 UTC) #5
On 2010/06/11 08:10:03, mat.mannion wrote:
> On 2010/06/11 06:19:12, gagan.goku wrote:
> > On 2010/06/10 01:56:19, zhoresh wrote:
> > > Submitted as r953197
> > 
> > Thanks Ziv
> 
> Excellent; thanks very much :)
Thanks.
Closing this issue.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b