src/pkg/path/filepath/path.go - Issue 160200044: [dev.power64] code review 160200044: build: merge default into dev.power64

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/path/filepath/path.go

Issue 160200044: [dev.power64] code review 160200044: build: merge default into dev.power64 (Closed)

Patch Set: diff -r be0c14f62257b42485019e9e1db23cf40d2e249f https://code.google.com/p/go Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/path/filepath/path.go

===================================================================

--- a/src/pkg/path/filepath/path.go

+++ b/src/pkg/path/filepath/path.go

@@ -231,6 +231,10 @@

// working directory to turn it into an absolute path. The absolute

// path name for a given file is not guaranteed to be unique.

func Abs(path string) (string, error) {

+ return abs(path)

+func unixAbs(path string) (string, error) {

if IsAbs(path) {

return Clean(path), nil

}

@@ -448,13 +452,6 @@

i--

}

dir := Clean(path[len(vol) : i+1])

- last := len(dir) - 1

- if last > 0 && os.IsPathSeparator(dir[last]) {

- dir = dir[:last]

- }

- if dir == "" {

- dir = "."

- }

return vol + dir

}

« no previous file with comments | « src/pkg/os/stat_windows.go ('k') | src/pkg/path/filepath/path_plan9.go » ('j') | no next file with comments »