Issue 1593042: code review 1593042: go/parser: correct position of empty statement ';'

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1593042: code review 1593042: go/parser: correct position of empty statement ';' (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by gri

Modified:
14 years, 9 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

go/parser: correct position of empty statement ';' (caused certain files to not be idempotent under gofmt) - corrected golden files for go/printer - slightly simplified some code in nodes.go (no impact on formatting) - these changes have no impact on gofmt output of .go files under src, misc fallthrough statement considered harmful!

Patch Set 1 #

Patch Set 2 : code review 1593042: go/parser: correct position of empty statement ';' #

Patch Set 3 : code review 1593042: go/parser: correct position of empty statement ';' #

Patch Set 4 : code review 1593042: go/parser: correct position of empty statement ';' #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -10 lines)			Patch
M	src/pkg/go/parser/parser.go	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/pkg/go/printer/nodes.go	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/go/printer/testdata/statements.golden	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 9 months ago (2010-06-08 23:49:37 UTC) #1

gri

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 9 months ago (2010-06-09 00:02:57 UTC) #2

gri

14 years, 9 months ago (2010-06-09 00:06:34 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=b801340969e4 ***

go/parser: correct position of empty statement ';'
(caused certain files to not be idempotent under gofmt)

- corrected golden files for go/printer
- slightly simplified some code in nodes.go (no impact on formatting)
- these changes have no impact on gofmt output of .go files under src, misc

fallthrough statement considered harmful!

R=rsc
CC=golang-dev
http://codereview.appspot.com/1593042

Expand All Messages | Collapse All Messages